New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too big of runtime #105

Closed
ericmjonas opened this Issue Mar 26, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@ericmjonas
Collaborator

ericmjonas commented Mar 26, 2017

If a user creates a runtime that unpacks to be too large, make sure we deliver sane errors to the user.

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Mar 26, 2017

Collaborator

In particular the wrenhandler tries to download the pickled objects like data and the function before it deals with the handler. So this is a problem for multiple reasons

  • If func or data is too large, we will error
  • if there is left-over crap from a previous run, we will error
Collaborator

ericmjonas commented Mar 26, 2017

In particular the wrenhandler tries to download the pickled objects like data and the function before it deals with the handler. So this is a problem for multiple reasons

  • If func or data is too large, we will error
  • if there is left-over crap from a previous run, we will error
@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Mar 26, 2017

Collaborator

A reasonable workaround if the runtime ate up too much space on the last invocation can be to call map with use_cached_runtime=False

Collaborator

ericmjonas commented Mar 26, 2017

A reasonable workaround if the runtime ate up too much space on the last invocation can be to call map with use_cached_runtime=False

@shivaram shivaram added this to the v0.3 milestone Mar 29, 2017

@shivaram shivaram added the runtime label Mar 29, 2017

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Aug 26, 2017

Collaborator

Closed by PR #172

Collaborator

ericmjonas commented Aug 26, 2017

Closed by PR #172

@ericmjonas ericmjonas closed this Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment