New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception pickling #78

Closed
ericmjonas opened this Issue Mar 1, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@ericmjonas
Collaborator

ericmjonas commented Mar 1, 2017

See the comments on PR #47 at the end -- @ooq is still seeing unpickleable exceptions.

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Mar 19, 2017

Collaborator

@ooq We were referencing an exception that you had seen that couldn't be serialized and yet still had a problem -- do you have a testcase perhaps ? I can't find the original problem.

Collaborator

ericmjonas commented Mar 19, 2017

@ooq We were referencing an exception that you had seen that couldn't be serialized and yet still had a problem -- do you have a testcase perhaps ? I can't find the original problem.

@ooq

This comment has been minimized.

Show comment
Hide comment
@ooq

ooq Mar 20, 2017

Collaborator

@ericmjonas Sorry that I could not recall the exact exception I had.
Just curious, do we have a rough list of 1) what exceptions cannot be pickled? 2) what exceptions can be pickled but cannot be unpickled?
And, is Exception the only object that causes pickle/unpickle issues? Just want to make sure we don't have to stress out about exc_traceback. If exc_traceback is not the worry, why are we doing str(exc_traceback) here?

Collaborator

ooq commented Mar 20, 2017

@ericmjonas Sorry that I could not recall the exact exception I had.
Just curious, do we have a rough list of 1) what exceptions cannot be pickled? 2) what exceptions can be pickled but cannot be unpickled?
And, is Exception the only object that causes pickle/unpickle issues? Just want to make sure we don't have to stress out about exc_traceback. If exc_traceback is not the worry, why are we doing str(exc_traceback) here?

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Mar 20, 2017

Collaborator

Sometimes exc_traceback contains pieces of the exception that cannot be pickled and I wanted to be 100% sure things propagated correctly. I don't have a list, but we have example exceptions that I test in test_pickle.py where we create objects (and exceptions) that fail on either pickle or unpickle.

Collaborator

ericmjonas commented Mar 20, 2017

Sometimes exc_traceback contains pieces of the exception that cannot be pickled and I wanted to be 100% sure things propagated correctly. I don't have a list, but we have example exceptions that I test in test_pickle.py where we create objects (and exceptions) that fail on either pickle or unpickle.

ericmjonas added a commit that referenced this issue Mar 22, 2017

@ericmjonas ericmjonas closed this Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment