Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating the lambda we indiscriminately upload too much #98

Closed
ericmjonas opened this issue Mar 20, 2017 · 2 comments
Closed

When creating the lambda we indiscriminately upload too much #98

ericmjonas opened this issue Mar 20, 2017 · 2 comments
Milestone

Comments

@ericmjonas
Copy link
Collaborator

@ericmjonas ericmjonas commented Mar 20, 2017

PyWren's lambda indiscriminately uploads the entire source dir. If for some reason the user has put crap in there, such as a copy of the runtime, it gets uploaded as well and then the Lambda API errors telling us that the files are too big. It's really confusing. We should check that we are only uploading necessary files.

@ooq
Copy link
Collaborator

@ooq ooq commented Mar 20, 2017

Are you talking about users putting crap in python module folders?

@ericmjonas ericmjonas added this to the v0.2 milestone Mar 20, 2017
@ericmjonas
Copy link
Collaborator Author

@ericmjonas ericmjonas commented Mar 20, 2017

Yes, exactly, but it's not that bizarre of a use case:

  1. user clones pywren github
  2. user installs via pip -e
  3. User adds things to pywren source dir, not thinking about it. Maybe they download a runtime, as happened in this case
  4. Our default upload-all policy... uploads everything, confusing them.

I think the right answer here is a whitelist, which is easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.