add exclude modules argument to map#140
Merged
Merged
Conversation
Collaborator
|
Let's maybe have an example to document this? |
Collaborator
Author
|
Here is an example library.py: driver.py: |
Collaborator
Author
|
I've also added a test. @ericmjonas could you see if this is sufficient? |
ooq
reviewed
Jun 2, 2017
| fut = self.wrenexec.map(foo, [x], exclude_modules=["extmodule"]) | ||
| try: | ||
| fut[0].result() | ||
| self.fail("shouldn't happen") |
Collaborator
There was a problem hiding this comment.
If exclusion does not work, there might still be some exception because extmodule does not really exist right?
Collaborator
Author
There was a problem hiding this comment.
What do you mean? In this case extmodule exists right?
Collaborator
Author
There was a problem hiding this comment.
at the top. line 6.
Collaborator
|
I think this looks fine to me. @ooq do you want to take one final look ? |
Collaborator
|
Looks good. Will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude modules in map based on prefix
Fix to #136