-
Notifications
You must be signed in to change notification settings - Fork 101
add exclude modules argument to map #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's maybe have an example to document this? |
Here is an example library.py:
driver.py:
|
I've also added a test. @ericmjonas could you see if this is sufficient? |
fut = self.wrenexec.map(foo, [x], exclude_modules=["extmodule"]) | ||
try: | ||
fut[0].result() | ||
self.fail("shouldn't happen") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If exclusion does not work, there might still be some exception because extmodule does not really exist right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? In this case extmodule exists right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you import it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the top. line 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, I missed it.
I think this looks fine to me. @ooq do you want to take one final look ? |
Looks good. Will merge. |
Exclude modules in map based on prefix
Fix to #136