Remove cloudpickle dependency and use local cloudpickle. - #142
Merged
Conversation
Collaborator
|
Nice work debugging this @ooq ! LGTM. @ericmjonas Any thoughts on this ? If not lets merge this and make our builds green |
Collaborator
|
LGTM
…On Thu, Jun 15, 2017 at 2:24 PM, Shivaram Venkataraman < ***@***.***> wrote:
Nice work debugging this @ooq <https://github.com/ooq> ! LGTM. @ericmjonas
<https://github.com/ericmjonas> Any thoughts on this ? If not lets merge
this and make our builds green
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#142 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACPEvkvOZVDhdUuzA61tz7DxIxR1MG3ks5sEaEqgaJpZM4N6xNi>
.
|
shivaram
approved these changes
Jun 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the build error on master.
Somehow we are not using the local cloudpickle and the latest cloudpickle via pip is not compatible.