Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pylint cleanup #143
There are still some more warnings left. The current output of running
The other warnings of relative import seem more tricky to fix as from my testing we rely on relative imports to get the lambda runner to work correctly.
Also @ooq @ericmjonas it would be good if you could look at the list of disabled checks at https://github.com/pywren/pywren/blob/pylint/pylintrc#L84 and see if something should be enabled.
Ok I enabled a bunch of more rules and fixed issues raised in them. https://gist.github.com/shivaram/5e297f237fabd268b860f367fb2f9331 is the latest remaining errors.
Some of the remaining ones are about unused variables which I am a bit hesitant to change in this PR as that will need more careful reviewing ?
Looks all good, except one comment on how
SQSInvoker should be imported. Thanks for the PR, it's quite some lines!