Fix patching of storage handler config, then fix commandline - #167
Merged
ericmjonas merged 3 commits intoAug 22, 2017
Conversation
shivaram
reviewed
Aug 22, 2017
|
|
||
| return config_filename | ||
|
|
||
| def patch_storage_config(config_data): |
Collaborator
There was a problem hiding this comment.
Can we print a warning or something here ? I'm trying to understand if this is an unusual case where we need to tell the user that we are using s3 as the default storage or if this is an expected workflow
Collaborator
Author
|
For the time being this is 100% the expected workflow, because we are not
yet migrating user configurations. In a later release we should add a
warning, telling people to upgrade their config file format.
…On Tue, Aug 22, 2017 at 9:09 AM, Shivaram Venkataraman < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pywren/wrenconfig.py
<#167 (comment)>:
> @@ -60,6 +63,17 @@ def get_default_config_filename():
return config_filename
+def patch_storage_config(config_data):
Can we print a warning or something here ? I'm trying to understand if
this is an unusual case where we need to tell the user that we are using s3
as the default storage or if this is an expected workflow
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#167 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACPEpAJZV3wL6Fsbp1V30P0MAWr3e26ks5sav1EgaJpZM4O-yyu>
.
|
shivaram
approved these changes
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166 #162