New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patching of storage handler config, then fix commandline #167

Merged
merged 3 commits into from Aug 22, 2017

Conversation

Projects
None yet
2 participants
@ericmjonas
Collaborator

ericmjonas commented Aug 22, 2017

Fixes #166 #162

@@ -60,6 +63,17 @@ def get_default_config_filename():
return config_filename
def patch_storage_config(config_data):

This comment has been minimized.

@shivaram

shivaram Aug 22, 2017

Collaborator

Can we print a warning or something here ? I'm trying to understand if this is an unusual case where we need to tell the user that we are using s3 as the default storage or if this is an expected workflow

@shivaram

shivaram Aug 22, 2017

Collaborator

Can we print a warning or something here ? I'm trying to understand if this is an unusual case where we need to tell the user that we are using s3 as the default storage or if this is an expected workflow

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Aug 22, 2017

Collaborator
Collaborator

ericmjonas commented Aug 22, 2017

@ericmjonas ericmjonas merged commit 01ad8a6 into master Aug 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment