Skip to content

Fix patching of storage handler config, then fix commandline - #167

Merged
ericmjonas merged 3 commits into
masterfrom
enable-cli-functiontest-with-different-config
Aug 22, 2017
Merged

Fix patching of storage handler config, then fix commandline#167
ericmjonas merged 3 commits into
masterfrom
enable-cli-functiontest-with-different-config

Conversation

@ericmjonas

Copy link
Copy Markdown
Collaborator

Fixes #166 #162

Comment thread pywren/wrenconfig.py

return config_filename

def patch_storage_config(config_data):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we print a warning or something here ? I'm trying to understand if this is an unusual case where we need to tell the user that we are using s3 as the default storage or if this is an expected workflow

@ericmjonas

ericmjonas commented Aug 22, 2017 via email

Copy link
Copy Markdown
Collaborator Author

@ericmjonas
ericmjonas merged commit 01ad8a6 into master Aug 22, 2017
@Vaishaal
Vaishaal deleted the enable-cli-functiontest-with-different-config branch November 28, 2018 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants