Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix patching of storage handler config, then fix commandline #167
For the time being this is 100% the expected workflow, because we are not yet migrating user configurations. In a later release we should add a warning, telling people to upgrade their config file format.…
On Tue, Aug 22, 2017 at 9:09 AM, Shivaram Venkataraman < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pywren/wrenconfig.py <#167 (comment)>: > @@ -60,6 +63,17 @@ def get_default_config_filename(): return config_filename +def patch_storage_config(config_data): Can we print a warning or something here ? I'm trying to understand if this is an unusual case where we need to tell the user that we are using s3 as the default storage or if this is an expected workflow — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#167 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACPEpAJZV3wL6Fsbp1V30P0MAWr3e26ks5sav1EgaJpZM4O-yyu> .