Switch to region specific runtimes #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaram
reviewed
Aug 24, 2017
tests/test_simple.py
Outdated
| # NOTE: There is some probability we will hit the base key ? | ||
| self.assertNotEqual(future.run_status['runtime_s3_key_used'], | ||
| base_runtime_key) | ||
| # def test_no_shard(self): |
There was a problem hiding this comment.
just to be clear is this test not going to be applicable from here on or is it that we will add shards to the new region-specific runtimes as well ?
There was a problem hiding this comment.
Sorry I don't quite understand the question; All future runtimes, including those that are region-specific, will be sharded. Thus eliminating these tests.
This seems reasonable because:
- if you don't shard the runtime you run into performance issues really quickly
- All "sharding" technically is is sticking the runtime at some locations pointed to by the meta.json. So we could in the future support single-tarball sharding if we wanted with no change in code. In fact, for testing, I often don't fully shard and just have the meta.json point to a single tarball.
There was a problem hiding this comment.
Got it. I was just wondering which way we went in terms of all sharding vs. no sharding.
Do we still want to test the meta.json -> shards being picked up correctly ? If not we can just delete these tests.
|
Ok @shivaram got rid of that test |
shivaram
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes:
In particular, we now explicitly get the runtime meta.json instead of having the hack where we assume there is some root .tar.gz. This should have no user-visible impact; the sharded runtime has been default for quite a while.
We now have runtimes and associated buckets in all the major US regions, in public buckets. It's easy to add more, as well.
I am not tying this to the new runtime builder as technically they are independent. Old runtimes should work with this code as well.
Closes issue #164