New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to region specific runtimes #169

Merged
merged 6 commits into from Aug 26, 2017

Conversation

Projects
None yet
2 participants
@ericmjonas
Collaborator

ericmjonas commented Aug 23, 2017

This pull request changes:

  1. the defaults that we use for runtimes
  2. The way we lookup runtime information

In particular, we now explicitly get the runtime meta.json instead of having the hack where we assume there is some root .tar.gz. This should have no user-visible impact; the sharded runtime has been default for quite a while.

We now have runtimes and associated buckets in all the major US regions, in public buckets. It's easy to add more, as well.

I am not tying this to the new runtime builder as technically they are independent. Old runtimes should work with this code as well.

Closes issue #164

@ericmjonas

This comment has been minimized.

Show comment
Hide comment
@ericmjonas

ericmjonas Aug 26, 2017

Collaborator

Ok @shivaram got rid of that test

Collaborator

ericmjonas commented Aug 26, 2017

Ok @shivaram got rid of that test

@shivaram

Thanks @ericmjonas - LGTM

@ericmjonas ericmjonas merged commit f57c915 into master Aug 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment