New max-limit seatbelt#177
Merged
Merged
Conversation
shivaram
reviewed
Sep 3, 2017
shivaram
left a comment
shivaram
left a comment
Collaborator
There was a problem hiding this comment.
LGTM pending Travis. Minor nit: could we use something other than misc ? Something like scheduler ?
Collaborator
|
LGTM. Should we make it possible to pass the parameter in map()? |
Collaborator
Author
|
… On Sun, Sep 3, 2017 at 12:04 AM, Qifan Pu ***@***.***> wrote:
LGTM. Should we make it possible to pass the parameter in map()?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#177 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACPEtAMjwMxzmFC6uQ4qZ_MXbBVyC4sks5sek-agaJpZM4PLD1b>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to solve #176 for Risecamp @shivaram @ooq could you guys take a quick look