New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for file types #12

Closed
wuffi opened this Issue Jul 4, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@wuffi

wuffi commented Jul 4, 2018

Thanks a lot for making the mindr package available. I like the idea a lot.
The outline() function looks for files with any extension in a given directory, which can cause problems, if there are other files than .Rmd or .md.
My .Rmd files are located in a directory, which also contains PDF and other files, which also contain lines starting with #. This in turn causes the function call to strsplit() in the md2mm() function to crash.
To avoid this problem, it might be a good idea to add an additional (optional) option to the md2mm() function to filter for files with a certain extension, like, for example .Rmd or .md.

@pzhaonet

This comment has been minimized.

Owner

pzhaonet commented Jul 30, 2018

This is a very good idea. Thank you very much.

@pzhaonet

This comment has been minimized.

Owner

pzhaonet commented Sep 28, 2018

The new version 1.1.3 now supports the filter. Please update it and see the help.

@pzhaonet pzhaonet closed this Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment