Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify hidden HTML and avoid its detection as malware #607

Merged
merged 1 commit into from Mar 3, 2018

Conversation

Projects
None yet
3 participants
@pupi1985
Copy link
Contributor

commented Feb 16, 2018

@ProThoughts

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2018

cool! thanks for the quick fix.

@svivian

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2018

We use absolute positioning so that the image is pre-loaded and appears instantly when doing an action (to show something is happening). Unfortunately browsers don't load images inside display:none, so on a slow connection it can take a second for the icon to display, which defeats the purpose.

visibility:hidden does load the image but it takes up space on the page. We can add position:absolute; top:0 but we may be back to square one with that.

I don't think pre-loading via JS is feasible either as the image URL is part of the CSS (different themes have different loading icons).

@pupi1985 pupi1985 force-pushed the pupi1985:patch-103 branch from fee24cb to 0bd2a82 Mar 2, 2018

@pupi1985

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2018

I can confirm the browser caching issue. I amended the commit. The solution is overkill on purpose: to avoid any theme CSS change to incidentally make the hidden element visible.

@svivian svivian merged commit 6965766 into q2a:dev Mar 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@svivian

This comment has been minimized.

Copy link
Collaborator

commented Mar 3, 2018

OK thanks, hopefully this stops the bogus malware alert.

@ProThoughts

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2018

This is working, no malware alert now. I added this patch on below site.
https://sitecheck.sucuri.net/results/meta.question2answer.info

@ProThoughts

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2018

@svivian , I feel you should release q2a v1.8.1 because of this patch. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.