Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events made easy and tinymce #152

Closed
liedekef opened this Issue May 5, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@liedekef
Copy link

liedekef commented May 5, 2015

Hi,

the plugin is working fine with the combo qtranslate-x and EME, but there seems to be an issue with tinymce:
https://wordpress.org/support/topic/bug-when-switch-languages-on-visual-editor
I tried it on my local install and it seems to be the case for me too. Although in the generated html output I see some qtranxs-translatable class being added to the content div, the language switch only works for the text-mode. Maybe the sequence of loading the javascript is wrong (just a thought)?

Franky

@johnclause johnclause changed the title events made easy and tinycme events made easy and tinymce May 7, 2015

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented May 7, 2015

@liedekef Franky: this is indeed strange, it all looks very similar to standard post page, but somehow it does not work. Can you think of a difference why event page could behave differently? Do you do anything non-wp-standard to load TinyMCE? I believe, if everything is done in the same way as on a standard post page '/wp-admin/post.php', it will work.

@johnclause johnclause added the bug label May 7, 2015

@liedekef

This comment has been minimized.

Copy link
Author

liedekef commented May 7, 2015

I haven't changed the code to add tinymce in quite a while. I use the standard wp call wp_editor in eme_events.php:

wp_editor($event['event_notes'],"content");
@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented May 16, 2015

Hi Franky, would you have time to try the latest beta https://github.com/qTranslate-Team/qtranslate-x/releases/tag/3.3.2 ? I think this issue has disappeared, could you confirm?

@liedekef

This comment has been minimized.

Copy link
Author

liedekef commented May 16, 2015

That version seems to be working. May I ask what it is that is special for the EME tinymce editor?

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented May 17, 2015

I did not specifically worked on this issue, decided to take a look after the last round of changes to implement Integration Framework, and when I tried eme again, it worked. It is kind of hard to trace back now what was wrong, and maybe it is not important at this point, the only thing that comes in mind is that I moved line "qtx.addContentHooksTinyMCE();" to be executed always and not only on post.php. Ah, that is it, yes, you use admin.php to edit events, so that line was not fired for you before, which means it never worked, we missed it ;) Yes, normally, plugins would use post.php for any kind of posts, and "event" is one of them, but I guess you implemented your own framework.

I am closing it now, we can still write to a closed issue or may reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.