New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty menu item title messes up menu structure #255

Closed
cdauth opened this Issue Sep 11, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@cdauth

cdauth commented Sep 11, 2015

In qtranslate_frontend.php, menu items with an empty title are removed from the menu. Any sub-items of the item that is removed are not removed from the menu. This will cause Wordpress to display them as top-level menu items.

For example, create a menu like this:

- Test
- (Empty title)
    - Sub item 1
    - Sub item 2
- Test 2

It will be displayed like this:

- Test
- Sub item 1
- Sub item 2
- Test 2

If a menu item is removed, the sub-items should be removed too.

@johnclause

This comment has been minimized.

Show comment
Hide comment
@johnclause

johnclause Sep 11, 2015

Member

Good point, thank you for the report. Is there any chance you would submit a pull request with a code to fix it?

Member

johnclause commented Sep 11, 2015

Good point, thank you for the report. Is there any chance you would submit a pull request with a code to fix it?

johnclause added a commit that referenced this issue Sep 14, 2015

@johnclause

This comment has been minimized.

Show comment
Hide comment
@johnclause

johnclause Sep 14, 2015

Member

The fix will be in release 3.4.5, it is now on GitHub. Do you have a quick way to test it? Please, let me know if there is a problem.

Member

johnclause commented Sep 14, 2015

The fix will be in release 3.4.5, it is now on GitHub. Do you have a quick way to test it? Please, let me know if there is a problem.

@johnclause johnclause closed this Sep 14, 2015

@ouiliam

This comment has been minimized.

Show comment
Hide comment
@ouiliam

ouiliam Aug 13, 2017

this is still a problem on release 3.4.6.8 WP 4.8.1
add an empty custom menu item with # as URL (to be used as a submenu group title), and the order is messed up and changes to EN menu items are no longer properly mirrored in other languages.

when custom links are used, the custom link URL gets modified by qtranslate.

ouiliam commented Aug 13, 2017

this is still a problem on release 3.4.6.8 WP 4.8.1
add an empty custom menu item with # as URL (to be used as a submenu group title), and the order is messed up and changes to EN menu items are no longer properly mirrored in other languages.

when custom links are used, the custom link URL gets modified by qtranslate.

@ouiliam

This comment has been minimized.

Show comment
Hide comment
@ouiliam

ouiliam Aug 13, 2017

I found in your FAQ the solution to the custom link issue (&setlang=no) but the empty custom link menu items issue still remains.

ouiliam commented Aug 13, 2017

I found in your FAQ the solution to the custom link issue (&setlang=no) but the empty custom link menu items issue still remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment