Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing right margin / padding in admin bar language dropdown #269

Closed
ihorvorotnov opened this Issue Sep 21, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@ihorvorotnov
Copy link

ihorvorotnov commented Sep 21, 2015

Checked with current master branch and .org version of the plugin. Here's the screenshot:

2015-09-21_22-29-00

Will check the code tomorrow and send a PR.

@johnclause johnclause added the bug label Sep 26, 2015

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented Sep 26, 2015

Hi, Ihor, Any progress on this? I am glad you noticed this.

@ihorvorotnov

This comment has been minimized.

Copy link
Author

ihorvorotnov commented Sep 26, 2015

@johnclause I fixed it on my local install but it's a bit hacky - there's a little problem with markup. See the screenshot - there's missing active background color right after the flag, because the flag is positioned with background-position: right; - it can't be padded.

2015-09-26_20-11-27

I'll fix it properly in next few days.

And also I've modified language tabs styles - the default styles are way off the WP styles (underlined links, gradient background etc). If you like it, I can make it as another option or replace the default one. Here it is:

2015-09-26_20-18-01

Not a final version though - there's some issues with inconsistent margins on different pages / positions. What do you think?

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented Sep 26, 2015

Thanks a lot. How was that before when it was working right?

Let us not modify the default, this will upset a lot of people, who got used to it already. Custom LSB styles can be added under folder "admin/css/opLSBStyle", where they are automatically get loaded from.

johnclause added a commit that referenced this issue Oct 1, 2015

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented Oct 1, 2015

I partially fixed it through PHP code cited above.

"background-position: right 5px center;" works well everywhere, but safari.

Did you make anymore progress?

@benique

This comment has been minimized.

Copy link
Contributor

benique commented Oct 5, 2015

@johnclause background-position: right 5px center; works in Safari 9. I've used it in earlier versions as well.

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented Oct 5, 2015

Wow, indeed I have Safari 5.1.7, but I installed it like a year ago, how am I so outdated. I am talking about Safari on Windows. I went to http://www.apple.com/safari/ and cannot find download button, who do you upgrade?

Anyway, the way menu now, in the latest on GitHub, seems to be good enough, is not it?

I am closing this issue to move forward, we can still write into a closed issue same way as before, or we can re-open it, if needed later.

@johnclause johnclause closed this Oct 5, 2015

@benique

This comment has been minimized.

Copy link
Contributor

benique commented Oct 5, 2015

@johnclause Safari for Windows was unfortunately retired in 2012.

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented Oct 5, 2015

I tested it on ipad, indeed it works. Anyway I like the way it is now even better. Flags in drop down a shifted a little bit with respect to top flag, but it looks even better to me. Do you think I should change something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.