Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better flag assets paths; works if plugin is installed as mu-plugin #168

Merged
merged 1 commit into from May 30, 2015

Conversation

Projects
None yet
2 participants
@entr
Copy link
Contributor

entr commented May 29, 2015

Of course this doesn't provide full mu-plugin support but it is a step.

johnclause added a commit that referenced this pull request May 30, 2015

Merge pull request #168 from entr/master
better flag assets paths; works if plugin is installed as mu-plugin

@johnclause johnclause merged commit e1df8aa into qTranslate-Team:master May 30, 2015

@johnclause

This comment has been minimized.

Copy link
Member

johnclause commented May 30, 2015

Thank you, @entr, although I do not see a benefit in using 'path_join', it seems to only increase the execution time.

There is a lot more places where string 'plugins' is in use. I was always worried about it. I also watch for problems when people link some of the folders in the path to plugin to somewhere else, then FILE has link-resolved value and sometimes it is a trouble. I am not sure about the best way to deal with all of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.