Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for frame payloads with BLAKE2b #252

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@NoraCodes
Copy link
Contributor

commented Jul 2, 2019

Move all data (but not metadata) in the Frame into a Payload which has a utility function for validating its length and digest.

The only real question with this PR is, should we also validate metadata (an FCS, like Ethernet and some other wire protocols use)? This will make version interoperability much more difficult; if we add a field or change the size of a field, mismatched versions will be unable to validate each others' frames, unless we add an additional field to keep track of the version.

On the other hand, errors in e.g. the sequence number could be quite problematic for transmission and reassembly.

Add validation for frame payloads with BLAKE2b
Move all data (but not metadata) in the Frame into a Payload which has
utility function for validating its length and digest.
@spacekookie
Copy link
Member

left a comment

Looks good to me :)

@spacekookie spacekookie merged commit fc0b7e9 into qaul:master Jul 2, 2019

@NoraCodes NoraCodes deleted the NoraCodes:nora/validation-for-frames branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.