Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add validation for frame payloads with BLAKE2b #252
Move all data (but not metadata) in the Frame into a Payload which has a utility function for validating its length and digest.
The only real question with this PR is, should we also validate metadata (an FCS, like Ethernet and some other wire protocols use)? This will make version interoperability much more difficult; if we add a field or change the size of a field, mismatched versions will be unable to validate each others' frames, unless we add an additional field to keep track of the version.
On the other hand, errors in e.g. the sequence number could be quite problematic for transmission and reassembly.