Skip to content

Conversation

@KochTobi
Copy link
Member

@KochTobi KochTobi commented Aug 27, 2020

Fixes #51

EDIT: This PR is replaced by #54

sven1103 and others added 8 commits August 25, 2020 13:15
* Remove field access modifiers from life.qbic.datamodel.dtos.imaging.*.groovy

* Remove field access modifiers and add enum value final modifier to properties

* Remove field access modifier for parameters.*.groovy classes
@KochTobi KochTobi requested a review from a team August 27, 2020 12:57
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #53 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #53      +/-   ##
============================================
+ Coverage     18.56%   18.64%   +0.08%     
  Complexity      169      169              
============================================
  Files           101      101              
  Lines          1794     1786       -8     
  Branches        237      237              
============================================
  Hits            333      333              
+ Misses         1409     1401       -8     
  Partials         52       52              
Impacted Files Coverage Δ Complexity Δ
...oovy/life/qbic/datamodel/dtos/imaging/Image.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...life/qbic/datamodel/dtos/imaging/Instrument.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...y/life/qbic/datamodel/dtos/imaging/Location.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...os/imaging/parameters/AcquisitionParameters.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tronmicroscopy/ElectronMicroscopyParameters.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...s/lightmicroscopy/LightMicroscopyParameters.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...qbic/datamodel/dtos/imaging/properties/Area.groovy 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../datamodel/dtos/imaging/properties/Detector.groovy 100.00% <ø> (ø) 1.00 <0.00> (ø)
...odel/dtos/imaging/properties/Dimensionality.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
...model/dtos/imaging/properties/EmissionRange.groovy 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a50cf...70095d3. Read the comment docs.

KochTobi added a commit to qbicsoftware/parent-poms that referenced this pull request Aug 27, 2020
Requires data-model-lib release 1.10.1
qbicsoftware/data-model-lib#53
Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this PR as well! LGTM

@KochTobi KochTobi closed this Aug 28, 2020
@KochTobi KochTobi deleted the hotfix/1.10.1 branch August 28, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DTO getter methods not generated

4 participants