Annotate instrument information on image. #11
Conversation
|
This needs qbicsoftware/data-model-lib#52 to be merged. |
|
Requires qbicsoftware/parent-poms#61 |
KochTobi
dismissed
Steffengreiner’s stale review
The code does not run until the parent-pom is fixed which can not be done until the data-model-lib is released.
|
The DTO returns null instead of empty strings whenever fields are not set in the address qbicsoftware/data-model-lib#55 |
KochTobi
dismissed
wow-such-code’s stale review
The current version fails for missing address attributes.
| try { | ||
| mapAnnotationContent.add(new NamedValue("hardware.detector.type", instrumentHardware.getDetector().getType())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("hardware.objective", instrumentHardware.getObjective())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("manufacturer", instrument.getManufacturer())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("location.address.affiliation", instrumentLocationAddress.getAffiliation())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("location.address.country", instrumentLocationAddress.getCountry())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("location.address.street", instrumentLocationAddress.getStreet())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("location.address.zipCode", instrumentLocationAddress.getZipCode().toString())); | ||
| } catch (NullPointerException ignored) {} | ||
| try { | ||
| mapAnnotationContent.add(new NamedValue("location.roomId", instrumentLocation.getRoomId())); | ||
| } catch (NullPointerException ignored) {} |
There was a problem hiding this comment.
Suggestion: the underlying problem is, that the instrument properties can be null. So lets make sure they are never null, but empty Strings, Lists or empty objects.
There was a problem hiding this comment.
this needs to be addressed in the instrument constructor then.
There was a problem hiding this comment.
I created an issue in the data-model-lib qbicsoftware/data-model-lib#55
|
@luiskuhn @wow-such-code Is this still needed? if not, feel free to close this PR |
No description provided.