New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Linux metadata #10111

Closed
eszlari opened this Issue Jan 4, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@eszlari
Copy link

eszlari commented Jan 4, 2019

Please, rename your metadata according to the AppStream spec:
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html
Desktop Entry Specification:
https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html

This would mean:
qbittorrent.appdata -> org.qbittorrent.qBittorrent.appdata.xml
qbittorrent.desktop -> org.qbittorrent.qBittorrent.desktop
menuicons/*x*/apps/qbittorrent.png -> org.qbittorrent.qBittorrent.png

This would fix:
flathub/org.qbittorrent.qBittorrent#13
flathub/org.qbittorrent.qBittorrent#18

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this issue Jan 5, 2019

Use reverse DNS convention for metadata files naming
Also update appdata install path.

Closes qbittorrent#10111.
@Chocobo1

This comment has been minimized.

Copy link
Member

Chocobo1 commented Jan 5, 2019

@eszlari
Would you test PR #10117?
I omitted the images renaming since I didn't found any app using that convention on my machine.

@eszlari

This comment has been minimized.

Copy link

eszlari commented Jan 5, 2019

I tested your branch, it works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment