New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of file identification for recheck #10133

Open
GodinHeaven opened this Issue Jan 8, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@GodinHeaven
Copy link

GodinHeaven commented Jan 8, 2019

Please provide the following information

qBittorrent version and Operating System

v4.1.5 64-bit, Universal

What is the problem

Whenever there is more than one option for torrent location/ name qBittorrent (following a para-phrased Murphy's Law) chooses the wrong option, and re-downloads/errors/resets progress. QBittorrent appears to start from the erroneous preposition that any torrent requiring a recheck isn't there (as if it's doing the initial check upon torrent addition- which ironically assumes it's already completed).

What is the expected behavior

qBittorrent is aware of enabled options like temp folder and .!incomplete, and checks in temp folder+completed folder, and checks for files with and without the .!incomplete extension (if enabled).

Steps to reproduce

Move content through file-system, then point with .!incomplete enabled; Add an externally completed torrent (with temp or .!incomplete enabled). I haven't managed to personally test it, I will update when I test with temp folder enabled (I tested with it disabled, and lo and behold- no issues!).

Extra info(if any)

Referencing: https://qbforums.shiki.hu/index.php/topic,6520.0.html, #10109

I classify this as a bug, not wish-list because there is no reason (IMO) that qBittorrent should call a completed torrent a never-started torrent (especially if completed through qBittorrent). I have through limited testing managed to add an externally completed torrent successfully (with temp folder enabled), and moved it manually to a different category changed category, and still rechecked successfully. As such it may prove a little tricky to reproduce resulting in an infrequent bug, or perhaps it only manifests when it coincides with different a malfunction. In either case integrating expected behavior should rectify any future mishaps.

Never having enabled .!incomplete, I assume that a regular recheck on a torrent showing complete should work fine, though I wonder what would happen if a completion recheck resulted in 99.99%, then got rechecked before rectification, or if temp is enabled what would happen to that now-incomplete torrent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment