Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: when deleting items, offer to always delete torrent+files #10362

Open
AndroidDeveloperLB opened this Issue Mar 9, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@AndroidDeveloperLB
Copy link

AndroidDeveloperLB commented Mar 9, 2019

Usually, after some time, when I want to remove something I've downloaded, and make room for next things I want to download, I expect that removing it will remove not just the torrent, but also the files that were downloaded.

Currently, when I choose to delete, I see this:

image

And the checkbox is always unchecked.
I know I can choose to avoid the dialog:

image

But then choosing to delete is still of deletion of the torrents alone by default, and the only way to delete with the files is to use Shift+Delete key combination.

What I suggest:

  1. On the dialog, add checbox for "remember my choice" and "don't show again".
  2. Instead of a checkbox in the settings for showing the dialog, make it a choice of "upon deletion" :
  • "Show confirmation dialog - deletion of torrent"
  • "Show confirmation dialog - deletion of torrent+files"
  • "No confirmation dialog - deletion of torrent"
  • "No confirmation dialog - deletion of torrent+files"

Both of those cover each other.

Alternatively, it could at least be nice to assign the Delete key to actually delete the selected torrents with their files.

@FranciscoPombal

This comment has been minimized.

Copy link
Contributor

FranciscoPombal commented Mar 9, 2019

  1. Instead of a checkbox in the settings for showing the dialog, make it a choice of "upon deletion":
  • "Show confirmation dialog - deletion of torrent"

  • "Show confirmation dialog - deletion of torrent+files"

  • "No confirmation dialog - deletion of torrent"

  • "No confirmation dialog - deletion of torrent+files"

This seems to be the better option. It is clear to the user when looking at the settings. With option (1) you'd be left to wonder which behavior you set to be remembered.

Alternatively, it could at least be nice to assign the Delete key to actually delete the selected torrents with their files.

I would say that the delete key should always show a confirmation dialog, regardless of the chosen setting. This is to avoid data loss in case a user accidentally presses the delete key. Accidentally pressing a keyboard key is not that infrequent. The delete key, in particular, is near other important keys in a lot of keyboards, like print screen, page up, page down, etc, and/or others, depending on the specific keyboard.

Commands with potentially destructive behaviors requiring no confirmation are more suited for CLI interfaces/interfacing with daemons/scripting environments imo, since in these cases the user is paying more attention to what they're doing and ultimately nothing happens until return is pressed.

So I propose something like this:

Chosen setting Behavior using the GUI buttons Behaviour using the keyboard
"Show confirmation dialog - deletion of torrent" same as chosen setting same as chosen setting
"Show confirmation dialog - deletion of torrent+files" same as chosen setting same as chosen setting
"No confirmation dialog - deletion of torrent" same as chosen setting "Show confirmation dialog - deletion of torrent"
"No confirmation dialog - deletion of torrent+files" same as chosen setting "Show confirmation dialog - deletion of torrent+files"

EDIT: about shift + delete: when using this keyboard shortcut, the behavior should default to "Show confirmation dialog - deletion of torrent+files"

@AndroidDeveloperLB

This comment has been minimized.

Copy link
Author

AndroidDeveloperLB commented Mar 9, 2019

It could also be nice to have a toolbar button for deletion of both torrents and files.
But I don't need a confirmation dialog. I know what I'm doing when I press the Delete key, just as I know what I'm doing when I do it with the mouse.

Another possible alternative to confirmation dialog is something that exists on Android and on some of Google's website: Snackbar. If you delete an email on Gmail (app or website), for example, it doesn't ask you if you are sure about it. It shows a temporary text saying that it's about to delete in a few seconds, and gives you final option to undo your action with an "undo" button next to this message.

We could also have a history for torrents, so deletion could be just of the files and not of the torrents (unless they are too old, of course, and then they would automatically be deleted or some other alternative, like storing the Magnet link).
This is actually something I've wanted to request a long time. Sometimes I accidentally download the same thing that I've downloaded a while ago, and then I need to delete it again. If the app gave me a choice in this case (ignore or re-download), it could be great. I could also just mark the torrent as one I don't ever want to download again (maybe rating system?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.