Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrent queueing- min threshold not honored for "Max Active Torrents" #10378

Open
beerandt opened this Issue Mar 13, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@beerandt
Copy link

beerandt commented Mar 13, 2019

Please provide the following information

qBittorrent version and Operating System

4.1.5 windows 7 x64

If on linux, libtorrent and Qt version

(type here)

What is the problem

Torrents in excess of #set as "Maximum Active Torrents" (under torrent queueing) are queued, even if below minimum thresholds ("Do not count slow torrents..."

Settings for max active up and max active down seem to work as expected.

What is the expected behavior

Active torrents that do not meet the min thresholds should not be counted as active for the purpose of queueing.

Steps to reproduce

Set maximum active torrents setting at a value that exceeds actually active torrents. Set minimum threshold high enough that most/all torrents should not be counted as active for purposes of queueing.

Observe number of queued (status) torrents: equals # of resumed torrents - setting of maximum active torrents. Ie- behavior of maximum active torrents is not modified by the "Do not count slow torrents..." checkbox.

Extra info(if any)

In my case, this was first observed when exceeding 999 active torrents, which is the maximum value allowed in the setting. Allowing a value greater than 999 (or 0 for unlimited) would also be a helpful workaround. (Unless there is a reason I'm unaware of for a hard limit of 999.)

I am unable to test at a lower number until I have time to clone the machine to a VM.

@thalieht

This comment has been minimized.

Copy link
Contributor

thalieht commented Mar 13, 2019

It's by design in libtorrent as a safety net for too many active torrents #7754 (comment)

@beerandt

This comment has been minimized.

Copy link
Author

beerandt commented Mar 13, 2019

I thought that might be the case... But what threw me off is that it only seems to be a limit with torrent queueing enabled. If I uncheck that, the previously queued torrents statuses change to seeding, all ~1085 that I have resumed.

It seems like you would want the hard limit set without torrent queueing enabled, as queueing in itself is a limiting safety net.

Either way, I assume something isn't working as designed here.

@Supralateral

This comment has been minimized.

Copy link

Supralateral commented Mar 14, 2019

Allowing a value greater than 999 (or 0 for unlimited) would also be a helpful workaround.

You can use -1 for unlimited, I believe it says as such in a hover tooltip somewhere

@beerandt

This comment has been minimized.

Copy link
Author

beerandt commented Mar 14, 2019

I don't seem to get any tooltips within the settings window(s)... but setting -1 worked like a charm. Thanks!

@thalieht thalieht added the Libtorrent label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.