Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking with no password: why? #11214

Open
bean-drew opened this issue Sep 10, 2019 · 1 comment

Comments

@bean-drew
Copy link

commented Sep 10, 2019

Please provide the following information

qBittorrent version and Operating System

4.1.7 on macOS 10.14.6

What is the problem

If the lock button on the top toolbar is pressed (with no password set) the UI will still "lock" - asking for a password when attempting to re-open the Qbittorrent window - then opening when [blank] is entered as the password. May be the cause of #5219 where user thought a password was in place that they had never set.

What is the expected behavior

By electing not to set a password a user is effectively opting out of the lock functionality. Perhaps the lock button should do nothing in this case (perhaps throwing up a "functionality disabled as no password is set" notification), rather than "lock" and then prompt for a password that doesn't exist.

Steps to reproduce

Open Qbittorrent (version 4.1.7 on macOS) and click the lock button.

@Chocobo1 Chocobo1 added the GUI label Sep 11, 2019

@Chocobo1

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I confirm this in v4.1.7. However it is already fixed in v4.2.0 (upcoming release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.