Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Navigate transfer list in Dark Theme in alpha #11349

Open
jagannatharjun opened this issue Oct 9, 2019 · 5 comments

Comments

@jagannatharjun
Copy link
Contributor

commented Oct 9, 2019

Problem:
When using the dark theme with new theme support in alpha release, you can't actually navigate the transfer list as the entries are still in dark because the colors are hard coded and the dark theme is detected by qpallete

image

Expected Behavior:
The colors should change with the theme.

Suggested solution:
Implement our own qpallate class which can load color from the qss itself.
Just like here

@glassez what do you think?

@glassez

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

@glassez

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Of course, it should be handled by UI theme.

Implement our own qpallate class

Please explain it.

@jagannatharjun

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

UIThemeManager should also provide the application palette. I propose doing this by creating a class a dummy class with the properties as defined here (so that they can be read from QSS) which transforms these properties into QPallete which is used with qApp

OR
following this:

Warning: Do not use this function in conjunction with Qt Style Sheets. When using style sheets, the palette of a widget can be customized using the "color", "background-color", "selection-color", "selection-background-color" and "alternate-background-color".

Provide customization options inside the Options dialog or in JSON format in .qbtheme specific for the transfer list only.

@glassez

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

OR
following this:

From where is it?

When using style sheets, the palette of a widget can be customized using the "color", "background-color", "selection-color", "selection-background-color" and "alternate-background-color".

Seems like the better way...

Provide customization options inside the Options dialog

Disagree. Each theme creator should provide complete solution.

@jagannatharjun

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2019

How about using
https://doc.qt.io/qt-5/stylesheet-syntax.html#setting-qobject-properties

TransferListModel {
  qproperty-downloading-text-color: red;
  qproperty-forcedDownload-text-color: pink;
 ...
}

From where is it?

https://doc.qt.io/qt-5/qwidget.html#palette-prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.