Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different client names 4.1.9.1 #11537

Open
p43b1 opened this issue Nov 29, 2019 · 4 comments
Open

Different client names 4.1.9.1 #11537

p43b1 opened this issue Nov 29, 2019 · 4 comments

Comments

@p43b1
Copy link

@p43b1 p43b1 commented Nov 29, 2019

Please provide the following information

qBittorrent version and Operating System

4.1.9.1 - Windows 10

If on linux, libtorrent-rasterbar and Qt version

(type here)

What is the problem

qBittorrent name is reported differently (see picture)

Some clients are qBittorrent 4.1.9.1 others qBittorrent/4.1.9.1

What is the expected behavior

All versions should have the same client name

Steps to reproduce

Download a torrent and check peers' client names

Extra info(if any)

See image attached

Immagine

@Kolcha

This comment has been minimized.

Copy link
Contributor

@Kolcha Kolcha commented Nov 29, 2019

desktop clients reports own version use space as separator (top lines on screenshot), WebUI only (qbittorrent-nox) clients use slash (bottom lines on screenshot). this is just my observation based on my own experience

@p43b1

This comment has been minimized.

Copy link
Author

@p43b1 p43b1 commented Nov 29, 2019

desktop clients reports own version use space as separator (top lines on screenshot), WebUI only (qbittorrent-nox) clients use slash (bottom lines on screenshot). this is just my observation based on my own experience

Ah ok! Thank you I didn't know this!

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Nov 30, 2019

this is just my observation based on my own experience

I think the code doesn't differentiate. This would be dumb on our part if we did this. But I don't know why that happens. Unless there another fork (or fake client) out there posing as qbittorrent too.

@p43b1

This comment has been minimized.

Copy link
Author

@p43b1 p43b1 commented Dec 5, 2019

this is just my observation based on my own experience

I think the code doesn't differentiate. This would be dumb on our part if we did this. But I don't know why that happens. Unless there another fork (or fake client) out there posing as qbittorrent too.

@sledgehammer999 the issue is still present on 4.2.0. I see both user-agents : qBittorrent 4.2.0 and qBittorrent/4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.