Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert about unexisting download path #12230

Open
YuryMatveev opened this issue Mar 24, 2020 · 13 comments
Open

alert about unexisting download path #12230

YuryMatveev opened this issue Mar 24, 2020 · 13 comments
Labels

Comments

@YuryMatveev
Copy link

@YuryMatveev YuryMatveev commented Mar 24, 2020

qBittorrent version and Operating System

QB 4.2.1, Win10.

What is the problem

QBittorrent doesn't alert if currently chosen download path is not exists.

What is the expected behavior

To alert the user, that this path is no more exists.

Steps to reproduce

  1. download torrent to some folder on removable drive
  2. remove the drive
  3. download next torrent without checking path
  4. see, that download is marked successful, but files are nowhere.
@FranciscoPombal FranciscoPombal changed the title Feature request: alert about unexisting download path alert about unexisting download path Mar 24, 2020
@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 24, 2020

It shows a warning icon beside the path box. Don’t you see it?

@YuryMatveev

This comment has been minimized.

Copy link
Author

@YuryMatveev YuryMatveev commented Mar 24, 2020

example
The only difference I see: "Free space on disk: Unknown".
But this is quite out of view.

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 24, 2020

Strange. I get a warning ⚠️ icon beside the path input when directory doesn’t exist.

@YuryMatveev

This comment has been minimized.

Copy link
Author

@YuryMatveev YuryMatveev commented Mar 24, 2020

PS: exclamation mark suddenly appeared. After several minutes...
But I can't make it to appear again.

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 24, 2020

I think the pre-existing path is not checked instantly. This is a bug not a feature request.
@FranciscoPombal

@YuryMatveev

This comment has been minimized.

Copy link
Author

@YuryMatveev YuryMatveev commented Mar 24, 2020

Also, I don't think it prevents to start the torrent without peering into.
Maybe, just disable "OK" button, if there's "Unknown" disk space?

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 24, 2020

Yes. It’s problematic that the GUI/WebUI doesn’t prevent user from adding a torrent with wrong path or inadequate space. This can be added as a new feature.

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 24, 2020

No access to a windows machine to reproduce this with removal drives, so @thalieht @an0n666 if you want to give this a shot, feel free. Especially this bit:

PS: exclamation mark suddenly appeared. After several minutes...
But I can't make it to appear again.

@thalieht

This comment has been minimized.

Copy link
Contributor

@thalieht thalieht commented Mar 24, 2020

  1. see, that download is marked successful, but files are nowhere.

Did you try open destination folder? I did what you said but the torrent status became Errored: The system cannot find the path specified before it started downloading.

Kind of off-topic but related:

In Linux when i type in some random_letters that doesn't have a parent, it creates that folder in Desktop/random_letters/ and saves the torrent there. No idea if that's expected. The save path column shows random_letters/.

In Windows if i do the above, the torrent starts downloading a few KB and then becomes Stalled (only on qBt startup, pause-resume stays stalled) even though it continues trying to connect to peers. Maybe this contributes to all those "help my torrents are stalled" issues throughout the years.

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 24, 2020

Yes in windows you can’t download in a non existent directory. It would throw up I/O errors.

@YuryMatveev

This comment has been minimized.

Copy link
Author

@YuryMatveev YuryMatveev commented Mar 24, 2020

Yes in windows you can’t download in a non existent directory. It would throw up I/O errors.

It fully downloads to %TEMP% and then just deletes files. Torrent is marked green as completed.
Though, if there're leechers, probably it will show error.

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 24, 2020

Then that’s a serious issue and needs to be addressed by blocking a dload to non existent directory.

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 24, 2020

@thalieht

In Linux when i type in some random_letters that doesn't have a parent, it creates that folder in Desktop/random_letters/ and saves the torrent there. No idea if that's expected. The save path column shows random_letters/.

Definitely not expected.

In Windows if i do the above, the torrent starts downloading a few KB and then becomes Stalled (only on qBt startup, pause-resume stays stalled) even though it continues trying to connect to peers. Maybe this contributes to all those "help my torrents are stalled" issues throughout the years.

Good catch.

I never tried inputting random_strings as path because I just assumed inputting anything other than an absolute path would just not work, but if this is possible, it's insane, especially since it's not really clear what folder the files will be saved in (in one case it was "the Desktop", in another it simply didn't work, in another case who know what might happen). In the dialog qBittorrent should only accept valid absolute paths.

In the cli flags, I think it's acceptable to be support relative paths though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.