Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version of qbitTorrent does not recognise latest version of Python #12263

Open
iWrite4u opened this issue Mar 25, 2020 · 11 comments
Open

New Version of qbitTorrent does not recognise latest version of Python #12263

iWrite4u opened this issue Mar 25, 2020 · 11 comments
Labels

Comments

@iWrite4u
Copy link

@iWrite4u iWrite4u commented Mar 25, 2020

Please provide the following information

qBittorrent version and Operating System

Latest, OSX

If on linux, libtorrent-rasterbar and Qt version

(type here)

What is the problem

When opening the latest version of Qbitorrent, the search function is disabled. When I try and add , I get message "Your version of Python is 2.7.6, please upgrade for search engines to work". I have Python 2.7.6 on my machine, but my Python version is 3.8.1. This did not happen on the previous version. Have re-installed previous version, which behaves as expected.

What is the expected behavior

Search engines work as before

Steps to reproduce

Open latest version of Qbittorrent

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 25, 2020

I changed the issue title to be consistent with the issue description.
Python 2 support has been removed: #11813
Python 2 has been EOL'd: https://www.python.org/doc/sunset-python-2/

@FranciscoPombal FranciscoPombal changed the title New Version of qbitTorrent does not recognised latest version of Python New Version of qbitTorrent does not work with Python 2 Mar 25, 2020
@FranciscoPombal FranciscoPombal changed the title New Version of qbitTorrent does not work with Python 2 New Version of qbitTorrent does not work with Python 2.x Mar 25, 2020
@FranciscoPombal FranciscoPombal changed the title New Version of qbitTorrent does not work with Python 2.x New Version of qbitTorrent does not recognised latest version of Python Mar 25, 2020
@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 25, 2020

Sorry, for the misunderstanding, re-opening.

@FranciscoPombal FranciscoPombal changed the title New Version of qbitTorrent does not recognised latest version of Python New Version of qbitTorrent does not recognise latest version of Python Mar 25, 2020
@vangeliis

This comment has been minimized.

Copy link

@vangeliis vangeliis commented Mar 26, 2020

Hi,

Same problem here. I installed the latest version of python for Mac (3.8.2) configured the path /usr/local/bin/python -> ../../../Library/Frameworks/Python.framework/Versions/3.8/bin/python3 but search is still broken. Any clues?

I should point out that the new version of python is installed in /usr/local/bin/ while the old version that comes build-into macosx is located in /usr/bin/

@aaronrudkin

This comment has been minimized.

Copy link

@aaronrudkin aaronrudkin commented Mar 28, 2020

I have this on Windows as well; I have an install of 2.7 and 3.8; qBittorrent finds the 2.7 version and not the 3.8 version, then complains 2.7 is too old.

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 28, 2020

@jozsefsallai would your PR fix this issue by any chance? If so, you can add a "Closes" statement to it.

@jozsefsallai

This comment has been minimized.

Copy link

@jozsefsallai jozsefsallai commented Mar 29, 2020

My fix is Windows-specific, so it would fix @aaronrudkin's issue (provided that their Python 3 is called python3.exe) but it wouldn't have any effect on Mac.

It's kind of odd that it doesn't work on Mac to be honest, since the python lookup function first checks whether python3 exists in the PATH. If it doesn't, it goes with python as a fallback. And /usr/local/bin should be in the PATH.

Edit: The only explanation for why it doesn't detect python3 if it's clearly in the PATH is that maybe the Q_OS_UNIX macro didn't return true when the Mac build was made (which also wouldn't really make any sense). Either way my PR does remove this macro check.

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 29, 2020

If anyone can help test the PR on macOS, that would be great. If not, wait until it is merged and there is an official release that includes the fix, and then see if the issue is resolved.

@iWrite4u

This comment has been minimized.

Copy link
Author

@iWrite4u iWrite4u commented Mar 29, 2020

Happy to help test on OSX

@vangeliis

This comment has been minimized.

Copy link

@vangeliis vangeliis commented Mar 29, 2020

Happy to test as well. What do I need to do?

@jozsefsallai

This comment has been minimized.

Copy link

@jozsefsallai jozsefsallai commented Mar 29, 2020

@iWrite4u @vangeliis The PR in question is #12301. You can use the GitHub CLI to checkout the PR locally or just clone my fork at jozsefsallai/qbittorrent. Then follow this tutorial to compile qBittorrent from source on Mac.

Before you do that though, it would be nice to see the output of the following commands:

which python3
which python
python3 --version
python --version

My friend has both python2 and python3 installed and he claims that qBittorrent (v4.2.2) detects python3 just fine.

@vangeliis

This comment has been minimized.

Copy link

@vangeliis vangeliis commented Mar 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.