Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.2 Breaks rss ability to download feed webpages rolling back to 4.2.1 works #12270

Open
CeruleanSky opened this issue Mar 25, 2020 · 39 comments
Open

Comments

@CeruleanSky
Copy link

@CeruleanSky CeruleanSky commented Mar 25, 2020

Please provide the following information

qBittorrent version and Operating System

4.2.2 and Windows 10 18363.720

What is the problem

All rss feeds fail to download in 4.2.2 rolling back to 4.2.1 works. I went back and forth several times to confirm. I thought it might be due to having selected my vpn network adapter in advanced preferences, but changing Advanced->Network Interface to Any Interface and restarting did not fix the problem. Ipv6 is disabled on my adapter.

The udp/tcp ports it listens to seem to be be different in 4.2.1 (random/random) , but both set to the same in 4.2.2 (36005/36005), don't know if that makes any difference. I didn't change any settings related to that.

What is the expected behavior

Rss Feeds download successfully like they do in 4.2.1

Steps to reproduce

Open up qbittorrent 4.2.2 and wait for rss feeds to load, if you see a bunch of (X) icons but it works in 4.2.1 you have the same problem I do.

Extra info(if any)

Here is my config with many bytearrays and ip addresses,etc changed to [REDACTED], perhaps overzealously

qbittorrent.ini.txt

image
image

@greenbench

This comment has been minimized.

Copy link

@greenbench greenbench commented Mar 25, 2020

Same, BUT:
Don't use Proxy/VPN.
On 4.2.1 my settings was Network Interface > Any Interface. On 4.2.2 changing it to Local Area Connection and restarting did fix the problem. And then changing it back to Any Interface and it still works.
EDIT
After some "tests" it seems it is not related to "Network Interface/IP Address to bind to" settings.
When qB starting up with the Windows it shows RSS errors with "An unknown network-related error was detected" message. Clicking on refresh button does nothing. Only restart of the qB solves the problem.

@ljmerza

This comment has been minimized.

Copy link

@ljmerza ljmerza commented Mar 25, 2020

I do use VPN and this didn't work unfortunately. Reverting to 4.2.1 fixed it. I get the same logs as given above.

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 25, 2020

@glassez ping

@glassez

This comment has been minimized.

Copy link
Member

@glassez glassez commented Mar 25, 2020

Why didn't you provide error messages from your log?

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 26, 2020

Probably an issue with network selection code.

@glassez

This comment has been minimized.

Copy link
Member

@glassez glassez commented Mar 26, 2020

I didn't have time to test it thoroughly, I just did a couple of tests.
I updated qBittorrent to v4.2.2. When I run it first time all my RSS feeds are failed with "Unknown network error" (some other downloads are failed too). Then I click on refresh button and feeds are downloaded successfully.
When I restarted qBittorrent again all feeds are downloaded successfully the first time.

So it seems this isn't RSS related issue.

@greenbench

This comment has been minimized.

Copy link

@greenbench greenbench commented Mar 26, 2020

Yes, i edited the post, but for me clicking on refresh button doesn't help.

@CeruleanSky

This comment has been minimized.

Copy link
Author

@CeruleanSky CeruleanSky commented Mar 26, 2020

@glassez Thank you for looking at it. Unfortunately no combination of restarting and refreshing, even refreshing after a minute or even 5 minutes seems to work. I suppose it is good you eliminated that it is rss related. Are there nightly/daily build artifacts anywhere? I was going to try appveyor to narrow down things, at least a little bit, but I didn't see any artifacts

@AndyGHenderson

This comment has been minimized.

Copy link

@AndyGHenderson AndyGHenderson commented Mar 26, 2020

Same symptoms as others. As soon as I upgraded to 4.2.2 RSS feeds have failed with

Failed to download RSS feed at 'xxx'. Reason: An unknown network-related error was detected.

Manual update gives same result, Restarting QB doesn't help. Restarting Windows (fully patched 10) doesn't work. Reselecting VPN node (NordVPN) doesn't work.

Manually initiating downloads from RSS site works fine.

Rolling back to 4.2.1 works immediately.

Andy

@glassez

This comment has been minimized.

Copy link
Member

@glassez glassez commented Mar 26, 2020

I just tested this with my own qBittorrent build. It is based on almost the same code base as v4.2.2. But I still use Qt 5.13 in my dev environment:
qbt
I also don't use any VPNs. So the problem is either in the networking layer of Qt 5.14.1 (used in Windows build of qBittorrent v4.2.2) or in something related to the VPN.
@Chocobo1, have we changed anything in the network related code since v4.2.1?

@glassez glassez added Network and removed RSS labels Mar 26, 2020
@Chocobo1

This comment has been minimized.

Copy link
Member

@Chocobo1 Chocobo1 commented Mar 26, 2020

@Chocobo1, have we changed anything in the network related code since v4.2.1?

I don't think so, here is the git history: https://github.com/qbittorrent/qBittorrent/commits/master/src/base/net

@AndyGHenderson

This comment has been minimized.

Copy link

@AndyGHenderson AndyGHenderson commented Mar 26, 2020

FWIW, I'm using a feed from showrss with parameter magnets=true

That means all links are magnet links which seems to implicate the change to downloadmanager.cpp with comment: "Qt doesn't support Magnet protocol so we need to handle redirections manually"

Andy

@CeruleanSky

This comment has been minimized.

Copy link
Author

@CeruleanSky CeruleanSky commented Mar 26, 2020

@AndyGHenderson I have non-magnet rss feeds and they fail as well, it is possible that the manual handling has issues, if not in the modified code, perhaps in qt. If anybody has any builds and wants to triage I will test a few.

@AndyGHenderson

This comment has been minimized.

Copy link

@AndyGHenderson AndyGHenderson commented Mar 26, 2020

Just tried reinstalling 4.2.2 and adding the same feed url with magnets=false (gives .torrent URLs) and still no joy. Back to 4.2.1 and both versions work fine. I looked in Fiddler and the showrss URL is not redirected, it returns a standard 200 response.

Andy

@null-character

This comment has been minimized.

Copy link

@null-character null-character commented Mar 27, 2020

I have the same issue. And on 4.2.1 the issue would come up occasionally. Usually restarting the app would work but not always. After some time the feeds would start working.

On 4.2.2 nothing will make them work. Restarting the app, restarting the VM, or even reinstalling the app. They just won't work.

Also I know the feeds are not going offline because I use zabbix to monitor them and they are online when the issue occurs.

Not sure about others but RSS is a core feature that needs to work. Otherwise I start getting calls from people asking why their shows are not downloading...

@pencilbook

This comment has been minimized.

Copy link

@pencilbook pencilbook commented Mar 27, 2020

Same problem here

I'm only using qbittorrent because of the inbuilt RSS downloader, please fix it immediately.

@CeruleanSky

This comment has been minimized.

Copy link
Author

@CeruleanSky CeruleanSky commented Mar 27, 2020

Looking through the issue tickets, #12297 , #12253 and likely #12287 are all manifestations of the same underlying problem. While the RSS subsystem probably works fine, it is likely affected by vpn networking issue.

@glassez

This comment has been minimized.

Copy link
Member

@glassez glassez commented Mar 27, 2020

@sledgehammer999, seems Windows build of v4.2.2 has serious problems with networking.
...or are there Linux/MacOS users?

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Mar 27, 2020

Question is, is this libtorrent or qt related?

I probably need to provide a qt 5.13 for testing...

@AndyGHenderson

This comment has been minimized.

Copy link

@AndyGHenderson AndyGHenderson commented Mar 27, 2020

@sledgehammer999, seems Windows build of v4.2.2 has serious problems with networking.
...or are there Linux/MacOS users?

Looking through the issue tickets, #12297 , #12253 and likely #12287 are all manifestations of the same underlying problem. While the RSS subsystem probably works fine, it is likely affected by vpn networking issue.

That could be right, but with this release the problem is a solid one - it doesn't go away with a restart.

Andy

@an0n666

This comment has been minimized.

Copy link
Contributor

@an0n666 an0n666 commented Mar 27, 2020

Question is, is this libtorrent or qt related?

I probably need to provide a qt 5.13 for testing...

Provide build with the libtorrent used in 4.2.1 as well.

@glassez

This comment has been minimized.

Copy link
Member

@glassez glassez commented Mar 27, 2020

Question is, is this libtorrent or qt related?

RSS subsystem has nothing to do with libtorrent (at least when it loads RSS feeds).
Anyway all interactions with libtorrent are performed via the same abstraction layer that are used everywhere across the app. So it's very unlikely that BitTorrent related issue can affect only RSS (or any other single) subsystem.

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Mar 27, 2020

Can you guys test the build below? It is v4.2.2 build with qt 5.13.2 (same as 4.2.1). The rest is the same as official 4.2.2.
Build: https://builds.shiki.hu/temp/qbittorrent_4.2.2_x64_for_issue_12270.7z

@CeruleanSky

This comment has been minimized.

Copy link
Author

@CeruleanSky CeruleanSky commented Mar 27, 2020

@sledgehammer999 that build works with me. All the rss feeds are loading now, which is how I noticed there was an issue.

If you need me to test anything else to perhaps narrow down what aspect of qt is the issue, just let me know.

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Mar 27, 2020

@CeruleanSky Thanks. I dug into the Qt bug tracker and I found this bug report: https://bugreports.qt.io/browse/QTBUG-80947

Apparently this bug affects Qt 5.14.0 and 5.14.1. It seems to be fixed in the unreleased Qt 5.14.2.
So next qbt version will use either 5.13.1 or 5.14.2+ (if they are released).

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 27, 2020

@CeruleanSky Thanks. I dug into the Qt bug tracker and I found this bug report: https://bugreports.qt.io/browse/QTBUG-80947

Apparently this bug affects Qt 5.14.0 and 5.14.1. It seems to be fixed in the unreleased Qt 5.14.2.
So next qbt version will use either 5.13.1 or 5.14.2+ (if they are released).

Amazing how a P1 bug reported at the end of last year did not make it into 5.14.1...
@glassez Any practical workarounds possible on our side until the patched version is released?

The only other alternative would be to release a version with qt 5.14.1 + the available patch, if 5.14.2+ takes too long.

@xavier2k6

This comment has been minimized.

Copy link

@xavier2k6 xavier2k6 commented Mar 27, 2020

@FranciscoPombal @sledgehammer999 FYI: currently only 4 fixes/blockers left before Qt5.14.2 is released.

Issues to be fixed before Qt 5.14.2

Meeting minutes from Qt Release Team meeting Tue 24th March 2020

Qt 5.14.2 status:

  • 'RC' packages created and couple of new blockers reported
  • Fixes are already integrating
  • Target is to create final packages tomorrow & get Qt 5.14.2 out still during this week.
@xavier2k6

This comment has been minimized.

Copy link

@xavier2k6 xavier2k6 commented Mar 28, 2020

Just thought of something, how about releasing a test build compiled from Qt 5.14.2 snapshot repo?

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Mar 28, 2020

If possible I would release a v4.2.3 this weekend if #12282 is merged. (probably with qt 5.13.2)

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Mar 28, 2020

Just thought of something, how about releasing a test build compiled from Qt 5.14.2 snapshot repo?

I don't really have the will, time, and strength into starting to make Qt git builds.

@xavier2k6

This comment has been minimized.

Copy link

@xavier2k6 xavier2k6 commented Mar 28, 2020

I scrapped the idea as the last snapshot was from Feb.....so no dice.

@FranciscoPombal

This comment has been minimized.

Copy link
Member

@FranciscoPombal FranciscoPombal commented Mar 28, 2020

@sledgehammer999

If possible I would release a v4.2.3 this weekend if #12282 is merged. (probably with qt 5.13.2)

Good idea. In addition, I think merging #12282 should not be dependent on having additional logic/external tools to fix the fastresume breakage that has already happened. That can wait, it's already spilled milk, let's try to prevent breakage for more users.

@AndyGHenderson

This comment has been minimized.

Copy link

@AndyGHenderson AndyGHenderson commented Mar 28, 2020

Can you guys test the build below? It is v4.2.2 build with qt 5.13.2 (same as 4.2.1). The rest is the same as official 4.2.2.
Build: https://builds.shiki.hu/temp/qbittorrent_4.2.2_x64_for_issue_12270.7z

Sorry, my media centre is 32-bit,

Andy

@greenbench

This comment has been minimized.

Copy link

@greenbench greenbench commented Mar 28, 2020

Can you guys test the build below? It is v4.2.2 build with qt 5.13.2 (same as 4.2.1). The rest is the same as official 4.2.2.
Build: https://builds.shiki.hu/temp/qbittorrent_4.2.2_x64_for_issue_12270.7z

It works, thanks!

@c0re100

This comment has been minimized.

Copy link

@c0re100 c0re100 commented Mar 28, 2020

If possible I would release a v4.2.3 this weekend if #12282 is merged. (probably with qt 5.13.2)

Wait.....
If next release using Qt 5.13.2, macOS Catalina will disappear toolbar again.
#11612

@sledgehammer999

This comment has been minimized.

Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Mar 28, 2020

If next release using Qt 5.13.2, macOS Catalina will disappear toolbar again.

Only the Windows build will use 5.13.2

@c0re100

This comment has been minimized.

Copy link

@c0re100 c0re100 commented Mar 28, 2020

If next release using Qt 5.13.2, macOS Catalina will disappear toolbar again.

Only the Windows build will use 5.13.2

Oh i see.

@pro4tlzz

This comment has been minimized.

Copy link

@pro4tlzz pro4tlzz commented Mar 28, 2020

so my RSS feeds do not update it i start qBittorrent then connect my VPN. Once I restart qBittorrent with my VPN still active it lets me download feeds. This is with any interface set for network binding.

@greenbench

This comment has been minimized.

Copy link

@greenbench greenbench commented Mar 28, 2020

so my RSS feeds do not update it i start qBittorrent then connect my VPN. Once I restart qBittorrent with my VPN still active it lets me download feeds. This is with any interface set for network binding.

Test this build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.