New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading different files with the same name from different torrents overwrites them #7676

Open
oxalfe opened this Issue Nov 4, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@oxalfe

oxalfe commented Nov 4, 2017

This issue has been reported in 3808 4417 4938 5661 6825, but none are closed, so I would like to know if it's even possible to fix.

Suppose you have two different torrents with the following structure:

ExampleTorrent
Size: 523.47 MB Files: 2 AddTime: 2015-02-17 09:09:07

File.wmv 523.47 MB
dummy 0 B

ExampleTorrent
Size: 987.54 MB Files: 3 AddTime: 2015-02-12 20:26:06

File.wmv 987.54 MB
dummy 0 B
dummy2 0 B

Both torrents will be downloaded to the same folder, which will cause an error, or if the option "Keep incomplete torrents in:" is activated, one of them will overwrite the other when both finish.

qBittorrent should display some warning, or keep the structure that creates for incomplete torrents.

@reyaz006

This comment has been minimized.

Show comment
Hide comment
@reyaz006

reyaz006 Dec 6, 2017

The real problem is:
When I rename the file inside qbt, I expect it to stay like that. I download a second torrent with the file named exactly like the one already present in the folder and in torrents list, I rename it in qbt, to make sure that both files are kept. But it fails to properly do that. It can do that once and I will see that both files are fine. I even pause both torrents to make sure qbt doesn't touch them anymore. But then, at some point, especially after restarting qbt or after PC crash, after qbt is started again, it'll do some processing through those torrents and files. It'll reset the custom file name. It'll wipe one version of the file and will try to download the other version of it from the second torrent.

Right now, the only way to make sure that my downloaded files are safe is to remove corresponding torrent from qbt. This is awful and embarrassing.

reyaz006 commented Dec 6, 2017

The real problem is:
When I rename the file inside qbt, I expect it to stay like that. I download a second torrent with the file named exactly like the one already present in the folder and in torrents list, I rename it in qbt, to make sure that both files are kept. But it fails to properly do that. It can do that once and I will see that both files are fine. I even pause both torrents to make sure qbt doesn't touch them anymore. But then, at some point, especially after restarting qbt or after PC crash, after qbt is started again, it'll do some processing through those torrents and files. It'll reset the custom file name. It'll wipe one version of the file and will try to download the other version of it from the second torrent.

Right now, the only way to make sure that my downloaded files are safe is to remove corresponding torrent from qbt. This is awful and embarrassing.

@dojima

This comment has been minimized.

Show comment
Hide comment
@dojima

dojima Mar 8, 2018

Just had this happen to me. This is a major issue. How can it start a torrent download without checking the hash of an identically named file?? This is like torrenting 101, come on...

For now, I guess I just have to use the append .!qB extension option to mitigate the chance that this happens. Awful.

dojima commented Mar 8, 2018

Just had this happen to me. This is a major issue. How can it start a torrent download without checking the hash of an identically named file?? This is like torrenting 101, come on...

For now, I guess I just have to use the append .!qB extension option to mitigate the chance that this happens. Awful.

@taltamir

This comment has been minimized.

Show comment
Hide comment
@taltamir

taltamir Sep 27, 2018

This is a fairly basic thing that needs fixing. The most basic of fixes is to pop up a question to the user on torrent adding that says there is a collision, asking them if they wish to overwrite, put the torrent in a subfolder, or manually rename the file

taltamir commented Sep 27, 2018

This is a fairly basic thing that needs fixing. The most basic of fixes is to pop up a question to the user on torrent adding that says there is a collision, asking them if they wish to overwrite, put the torrent in a subfolder, or manually rename the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment