New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder watching under Linux might be broken for SMB2/3 network filesystems. #9671

Closed
Cilph opened this Issue Oct 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Cilph

Cilph commented Oct 9, 2018

Please provide the following information

qBittorrent version and Operating System

qBittorrent 4.1.3, Debian Linux 9

What is the problem

Running qBittorrent in a docker setup, watching a networked SMB folder (/downloads/watch/), results in no torrents being added either by inotify or polling. Except on startup and local changes. The folder is mounted as SMB3 (vers=3.0)

What is the expected behavior

The watched folder will be polled periodically.

Extra info(if any)

I've did some of my own investigation and found that stat reports the networked folder as of type smb2. Peeking into Utils::Fs::isNetworkFileSystem reveals checks for CIFS, NFS and SMB. SMB2 however uses a different magic number (0xFE534D42) compared to the one listed (0x517B) which seems to only match SMB1. This would result in no periodic polling being done on the watched folder. The difference being presumably because of the large protocol differences between SMB1 and SMB2/3. Adjusting my mount options to use SMB1 explicitly (vers=1.0) seems to fix the issue entirely, seemingly confirming my hypothesis.

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this issue Oct 10, 2018

@Chocobo1

This comment has been minimized.

Show comment
Hide comment
@Chocobo1

Chocobo1 Oct 10, 2018

Member

Thanks for reporting! I've submitted PR #9673.

Member

Chocobo1 commented Oct 10, 2018

Thanks for reporting! I've submitted PR #9673.

@Chocobo1 Chocobo1 closed this in 25a0147 Oct 11, 2018

@Chocobo1

This comment has been minimized.

Show comment
Hide comment
@Chocobo1

Chocobo1 Oct 11, 2018

Member

Will be fixed in next release v4.1.4.

Member

Chocobo1 commented Oct 11, 2018

Will be fixed in next release v4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment