New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash 4.1.3 on Windows 10 #9819

Open
CraigHead opened this Issue Nov 5, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@CraigHead

CraigHead commented Nov 5, 2018

qBittorrent version and Operating System

qBittorrent version: v4.1.3 (64-bit)
Libtorrent version: 1.1.9.0
Qt version: 5.11.1
Boost version: 1.68.0
OS version: Windows 10 (10.0) 10.0.17134 x86_64

What is the problem

Crash. Based on what I can see in the stack trace, it's possible that a bug might be near NET DNS Resolution in peer list.

Caught signal: SIGSEGV

#  0 qbittorrent.exe      0x00007ff705d467ce straceWin::getBacktrace()[ app\stacktrace_win.h : 213 ]
#  1 qbittorrent.exe      0x00007ff705d4a10d sigAbnormalHandler(signum)[ app\main.cpp : 302 ]
#  2 qbittorrent.exe      0x00007ff706987291 _seh_filter_exe(xcptnum, pxcptinfoptrs)[ minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp : 215 ]
#  3 qbittorrent.exe      0x00007ff706a688f6 `__scrt_common_main_seh'::`1'::filt$0()[ f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl : 299 ]
#  4 qbittorrent.exe      0x00007ff706967580 __C_specific_handler(ExceptionRecord, EstablisherFrame, ContextRecord, DispatcherContext)
#  5 ntdll.dll            0x00007fff8069ed2d _chkstk()
#  6 ntdll.dll            0x00007fff80606c86 RtlWalkFrameChain()
#  7 ntdll.dll            0x00007fff8069dc5e KiUserExceptionDispatcher()
#  8 qbittorrent.exe      0x00007ff705daced0 QCache::~QCache()[ g:\qbittorrent\install_msvc64\qt5\include\qtcore\qcache.h : 93 ]
#  9 qbittorrent.exe      0x00007ff705daca66 Net::ReverseResolution::`scalar deleting destructor'()
# 10 qbittorrent.exe      0x00007ff705df3526 PeerListWidget::~PeerListWidget()[ gui\properties\peerlistwidget.cpp : 152 ]
# 11 qbittorrent.exe      0x00007ff705df346d PeerListWidget::`scalar deleting destructor'()
# 12 qbittorrent.exe      0x00007ff705e0697a PropertiesWidget::~PropertiesWidget()[ gui\properties\propertieswidget.cpp : 174 ]
# 13 qbittorrent.exe      0x00007ff705e068ad PropertiesWidget::`scalar deleting destructor'()
# 14 qbittorrent.exe      0x00007ff70678e4d3 QObjectPrivate::deleteChildren()
# 15 qbittorrent.exe      0x00007ff7062b6ea9 QWidget::~QWidget()
# 16 qbittorrent.exe      0x00007ff70635668d QSplitter::`vector deleting destructor'()
# 17 qbittorrent.exe      0x00007ff70678e4d3 QObjectPrivate::deleteChildren()
# 18 qbittorrent.exe      0x00007ff7062b6ea9 QWidget::~QWidget()
# 19 qbittorrent.exe      0x00007ff70635668d QSplitter::`vector deleting destructor'()
# 20 qbittorrent.exe      0x00007ff70678e4d3 QObjectPrivate::deleteChildren()
# 21 qbittorrent.exe      0x00007ff7062b6ea9 QWidget::~QWidget()
# 22 qbittorrent.exe      0x00007ff706314b22 QFrame::`vector deleting destructor'()
# 23 qbittorrent.exe      0x00007ff70678e4d3 QObjectPrivate::deleteChildren()
# 24 qbittorrent.exe      0x00007ff7062b6ea9 QWidget::~QWidget()
# 25 qbittorrent.exe      0x00007ff705e40edd HidableTabWidget::`scalar deleting destructor'()
# 26 qbittorrent.exe      0x00007ff70678e4d3 QObjectPrivate::deleteChildren()
# 27 qbittorrent.exe      0x00007ff7062b6ea9 QWidget::~QWidget()
# 28 qbittorrent.exe      0x00007ff7062b537d QWidget::`vector deleting destructor'()
# 29 qbittorrent.exe      0x00007ff705e4bbe5 MainWindow::cleanup()[ gui\mainwindow.cpp : 805 ]
# 30 qbittorrent.exe      0x00007ff705d3de43 Application::cleanup()[ app\application.cpp : 703 ]
# 31 qbittorrent.exe      0x00007ff705d3fa7c QtPrivate::QSlotObject,void>::impl(which, this_, r, a, ret)[ g:\qbittorrent\install_msvc64\qt5\include\qtcore\qobjectdefs_impl.h : 396 ]
# 32 qbittorrent.exe      0x00007ff706792347 QMetaObject::activate()
# 33 qbittorrent.exe      0x00007ff7067cd155 QCoreApplication::aboutToQuit()
# 34 qbittorrent.exe      0x00007ff7067ca0ee QCoreApplication::exec()
# 35 qbittorrent.exe      0x00007ff705d49fc5 main(argc, argv, argv)[ app\main.cpp : 253 ]
# 36 qbittorrent.exe      0x00007ff70695f7fb WinMain()
# 37 qbittorrent.exe      0x00007ff7069659c6 __scrt_common_main_seh()[ f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl : 283 ]
# 38 KERNEL32.DLL         0x00007fff7dc13034 BaseThreadInitThunk()
# 39 ntdll.dll            0x00007fff80671461 RtlUserThreadStart()

What is the expected behavior

For the app to no crash.

Steps to reproduce

Start a torrent. This crash appears to be random. Perhaps an artifact of a race condition?

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this issue Nov 5, 2018

Fix potential crash
`m_searchFilterAction` is allocated inside Qt, so we shouldn't delete it
manually.

Closes qbittorrent#9819.

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this issue Nov 5, 2018

Don't double delete a pointer
`m_searchFilterAction` is allocated inside Qt, so we shouldn't delete it
manually.
Closes qbittorrent#9819.

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this issue Nov 5, 2018

Don't double delete a pointer
`m_searchFilterAction` is owned by Qt, so we shouldn't delete it
manually.
Closes qbittorrent#9819.
@Chocobo1

This comment has been minimized.

Member

Chocobo1 commented Nov 8, 2018

oops...

@Chocobo1 Chocobo1 reopened this Nov 8, 2018

@JSebastianN

This comment has been minimized.

JSebastianN commented Nov 18, 2018

I experience this :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment