Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zlib version #10788

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@silverqx
Copy link
Contributor

commented Jun 10, 2019

Add zlib version to libraries tab in about dialog and to stacktrace dialog.

Closes #10240

@Chocobo1

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@silverqx
There is also webui, are you interested adding to it?

@Piccirello

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

If you are willing to add it to the WebUI, #10096 might point you in the right direction.

@silverqx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@Piccirello @Chocobo1 Good idea, I can add it

@silverqx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@silverqx: I take it you modeled this PR after [#9980]?

Something like that :), I tried to recompile with different versions, ... thx for close #10240 I didn't notice

@Piccirello
Copy link
Contributor

left a comment

Approving webui changes

@Chocobo1

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@silverqx
LGTM. Please squash commits into one.

@silverqx silverqx force-pushed the silverqx:add-zlib-version-to-gui branch from 04d649f to 4f4f435 Jun 12, 2019

@Chocobo1 Chocobo1 merged commit a65f365 into qbittorrent:master Jun 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Chocobo1

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@silverqx
Thanks!

@Chocobo1 Chocobo1 added this to the 4.2.0 milestone Jun 13, 2019

@Chocobo1 Chocobo1 changed the title Add zlib version to GUI & stackdump Add zlib version Jun 13, 2019

@silverqx silverqx deleted the silverqx:add-zlib-version-to-gui branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.