Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid word wrap in webui footer #10867

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
5 participants
@airium
Copy link
Contributor

commented Jun 28, 2019

Previous:
TIM图片20190629005525
After:
TIM截图20190629012140

BTW, how about also applying this to the speed labels? i.e. replacing the min-width: 18em; in td.speedLabel.

@Chocobo1 Chocobo1 added this to the 4.2.0 milestone Jun 29, 2019

@Chocobo1 Chocobo1 added the WebUI label Jun 29, 2019

@Ryrynz

This comment has been minimized.

Copy link

commented Jun 30, 2019

We're waiting on Sledge to be free to release 4.1.7 yeah? Might as well throw this one in the backport mix.

@Chocobo1

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

replacing the min-width: 18em; in td.speedLabel.

But won't that cause the label to shrink/enlarge every time when the label text width changed?
I suppose it is alright to add white-space: nowrap; instead of replacing min-width.

@airium

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

But won't that cause the label to shrink/enlarge every time when the label text width changed?

You're right. But I think a flexible width may be better when you are narrowing the window.

@Chocobo1

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

@Piccirello Oops, I accidentally clicked on assigning this to you, it wasn't my intention, I meant to ping you to review/comments.

@Chocobo1
Copy link
Member

left a comment

LGTM

@Piccirello

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

I’ll try to review tonight

@airium

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

I’ll try to review tonight

Thanks. Please tell me how you think and I will modify accordingly.

@glassez

glassez approved these changes Jul 4, 2019

@Chocobo1 Chocobo1 merged commit 0aa6f39 into qbittorrent:master Jul 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Chocobo1

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@airium
Thank you!

@Piccirello
I think this is a relatively safe change, we can improve it if there are any imperfection.

@Piccirello

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Apologies for not reviewing this. Testing it now and it looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.