Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save preferences until all options are processed #11057

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@Piccirello
Copy link
Contributor

commented Aug 11, 2019

New options have been added to this api, but the apply() logic was never moved down. The options should have been added before apply().

@Piccirello Piccirello added the WebAPI label Aug 11, 2019

@Chocobo1
Copy link
Member

left a comment

Good find!

@Chocobo1 Chocobo1 added this to the 4.2.0 milestone Aug 12, 2019

@Chocobo1 Chocobo1 merged commit 8555629 into qbittorrent:master Aug 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Chocobo1

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@Piccirello
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.