Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SettingsStorage behavior #11208

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@Chocobo1
Copy link
Member

commented Sep 8, 2019

No description provided.

Chocobo1 added 2 commits Sep 8, 2019

@Chocobo1 Chocobo1 added the Core label Sep 8, 2019

@Chocobo1 Chocobo1 added this to the 4.2.0 milestone Sep 8, 2019

@Chocobo1 Chocobo1 force-pushed the Chocobo1:storage branch from 29b20f1 to 6c42b96 Sep 8, 2019

Clean up SettingsStorage::save()
Also it should return `true` when `m_dirty` is `false`.

@Chocobo1 Chocobo1 force-pushed the Chocobo1:storage branch from 6c42b96 to 0a959bc Sep 8, 2019

@glassez
glassez approved these changes Sep 8, 2019

@Chocobo1 Chocobo1 merged commit b144d3b into qbittorrent:master Sep 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Chocobo1 Chocobo1 deleted the Chocobo1:storage branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.