Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename literal operator #19188

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Rename literal operator #19188

merged 3 commits into from
Jun 19, 2023

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Jun 17, 2023

Qt 6.4 introduced QString operator""_s() and the previous ""_qs is deprecated since Qt 6.8.

Related issue: #19184.

@Chocobo1 Chocobo1 added the Code cleanup Clean up the code while preserving the same outcome label Jun 17, 2023
@Chocobo1 Chocobo1 added this to the 4.6.0 milestone Jun 17, 2023
@Chocobo1 Chocobo1 requested a review from a team June 17, 2023 19:30
xavier2k6
xavier2k6 previously approved these changes Jun 17, 2023
Qt 6.4 introduced `QString operator""_s()` and the previous `""_qs` is
deprecated since Qt 6.8.
@Chocobo1 Chocobo1 merged commit 1f2a645 into qbittorrent:master Jun 19, 2023
@Chocobo1 Chocobo1 deleted the literalOperator branch June 19, 2023 04:45
@xavier2k6
Copy link
Member

@Chocobo1 @glassez Can I ask, I'm only asking here as this was the last place statusbar.cpp was touched & it has to do with deprecations.......

Briefly going through https://doc.qt.io/qt-6/obsoleteclasses.html & came across https://doc.qt.io/qt-6/qstyle-obsolete.html

Am I correct in thinking that below is deprecated too or am I misunderstanding?

restartIconLbl->setPixmap(style()->standardPixmap(QStyle::SP_MessageBoxWarning));

@thalieht
Copy link
Contributor

thalieht commented Sep 24, 2023

I'm only asking here as this was the last place statusbar.cpp was touched

FYI that line was last touched 6 years ago. Use View git blame to see it (where you can find Copy permalink)
https://github.com/qbittorrent/qBittorrent/blame/master/src/gui/statusbar.cpp#L162

@Chocobo1
Copy link
Member Author

Am I correct in thinking that below is deprecated too or am I misunderstanding?

You are correct. standardPixmap() should be replaced by standardIcon().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup Clean up the code while preserving the same outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants