New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes commit-by-commit part 1 #7566

Merged
merged 2 commits into from Oct 11, 2017

Conversation

Projects
None yet
4 participants
@zeule
Contributor

zeule commented Oct 10, 2017

As per discussion in #6698 I'm splitting that PR onto smaller ones. Here is the first part. No functional changes here, just code formatting and refactoring,

@zeule zeule requested review from sledgehammer999, glassez and Chocobo1 Oct 10, 2017

Show outdated Hide outdated src/base/torrentfilter.h
Show outdated Hide outdated src/base/preferences.cpp
@@ -59,7 +59,7 @@
Preferences *Preferences::m_instance = 0;
Preferences::Preferences() {}

This comment has been minimized.

@glassez

glassez Oct 10, 2017

Member

Question only for my interest... Why is the new version (with default) better than the former (with empty body)?

@glassez

glassez Oct 10, 2017

Member

Question only for my interest... Why is the new version (with default) better than the former (with empty body)?

This comment has been minimized.

@zeule

zeule Oct 10, 2017

Contributor

Just to give more coding flexibility and less format violation options.

@zeule

zeule Oct 10, 2017

Contributor

Just to give more coding flexibility and less format violation options.

Show outdated Hide outdated src/base/preferences.cpp
@@ -34,6 +34,8 @@
#include <QElapsedTimer>
#include <QVariant>
#include <libtorrent/version.hpp>

This comment has been minimized.

@Chocobo1

Chocobo1 Oct 10, 2017

Member

you need this later?

@Chocobo1

Chocobo1 Oct 10, 2017

Member

you need this later?

Show outdated Hide outdated src/gui/guiiconprovider.cpp
Show outdated Hide outdated src/base/preferences.cpp

magao and others added some commits Feb 12, 2017

Make BitTorrent::TorrentState strongly-typed enum
This is needed to forward declare this type and pass it by value.

Conversion from/to QVariant are hanled via Q_DECLARE_METATYPE, while
TorrentState::toString() function was used in webui only and as such is
moved there.
@zeule

This comment has been minimized.

Show comment
Hide comment
@zeule

zeule Oct 11, 2017

Contributor

Thanks!

Contributor

zeule commented Oct 11, 2017

Thanks!

@zeule zeule merged commit 7a652c0 into qbittorrent:master Oct 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment