Disable QDBus integration by default on Windows/Mac/Android#21
Merged
danvratil merged 1 commit intoqcoro:mainfrom Oct 17, 2021
Merged
Disable QDBus integration by default on Windows/Mac/Android#21danvratil merged 1 commit intoqcoro:mainfrom
danvratil merged 1 commit intoqcoro:mainfrom
Conversation
danvratil
requested changes
Oct 14, 2021
Collaborator
danvratil
left a comment
danvratil
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the patch.
Could you please also update .github/workflows/build.yml to explictly pass QCORO_WITH_DBUS=ON to CMake on all platforms? I want to make sure that the tests still pass even on Win32 (I don't have Apple or Android CI, yet).
These platforms generally don't have (Qt)DBus so building the support often makes no sense However in some cases it can make sense to have it so keep the ability to turn it on
nicolasfella
force-pushed
the
work/dbusnonlinux
branch
from
43ac226 to
b1eccea
Compare
danvratil
approved these changes
Oct 17, 2021
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These platforms generally don't have (Qt)DBus so building the support often makes no sense
However in some cases it can make sense to have it so keep the ability to turn it on