Return Task<T> from wrapper operations #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danvratil
force-pushed
the
feature/task-operations
branch
2 times, most recently
from
5e31c1b to
c59db9f
Compare
danvratil
force-pushed
the
feature/task-operations
branch
from
2363708 to
a31cfbe
Compare
This means that every operation provided by the QCoro wrapper
classes now returns a Task<T>, so it's possible to use .then()
continuations with any operations provided by QCoro, e.g.
qCoro(socket).waitForConnected(then([](bool ok) { ... });
Previously qCoro(socket).waitForConnected() would return an
instance of QCoroAbstractSocket::WaitForConectedOperation,
which is an implementation detail of QCoro, which makes it
hard to combine it with functions (not coroutines!) that
return Task<T> and makes it much harder to support .then()
continuations everywhere.
Apparently, QPointer::get() has been introduced in Qt6.
danvratil
force-pushed
the
feature/task-operations
branch
from
a31cfbe to
f4bc03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.