Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Github CI - add compilers and platforms #60

Merged
merged 7 commits into from
May 2, 2022
Merged

Conversation

danvratil
Copy link
Collaborator

Add multiple versions of GCC, clang, add apple-clang.

@danvratil danvratil force-pushed the ci/rework-ci branch 2 times, most recently from 8ddbac2 to 6d1d7f5 Compare April 27, 2022 18:40
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022

Unit Test Results

    9 files  +  2      9 suites  +2   6m 3s ⏱️ + 1m 10s
  14 tests ±  0    14 ✔️ +  1  0 💤 ±0  0  - 1 
120 runs  +26  120 ✔️ +28  0 💤 ±0  0  - 2 

Results for commit 97c4801. ± Comparison against base commit 4a18d6b.

♻️ This comment has been updated with latest results.

@danvratil danvratil force-pushed the ci/rework-ci branch 27 times, most recently from 1ea2669 to 97c4801 Compare May 2, 2022 19:41
@danvratil danvratil force-pushed the ci/rework-ci branch 2 times, most recently from 4cb544e to dd7c038 Compare May 2, 2022 20:10
Add multiple versions of GCC, clang, add apple-clang.
The socket state is local, so it's possible to report 'connected',
resume to coroutine finish it and destroy the socket before the
server has time to actually get the incoming connection. This
results in the test server being stopped by the test before it
actually starts waiting for incoming connection, causing the
server to incorrectly report the test as time out.

The fix is for the test to wait at the end for the server to
confirm it has gotten the incoming connection.
libc++ doesn't implement any concepts yet, use variable templates
instead.
…nnectedSocket

The test server expects a request and if none arrives, it fails.
@danvratil danvratil merged commit 60c235d into main May 2, 2022
@danvratil danvratil deleted the ci/rework-ci branch May 2, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants