Explicitly enable exception support for clang-cl (fixes #90) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC requires that exceptions are explicitly enabled using the `\EH` flag, so clang-cl copies that behavior. When CMake targets the Windows-MSVC platform (that is when using "Visual Studio" generator), CMake takes care of adding `\EHsc` to `CXXFLAGS`. However when the clang-cl compiler is specified manually (`CMAKE_CXX_COMPILER`) and another generator, like Ninja is used, then CMake ends up targeting the Windows-Clang-CXX platform, which does not enable exceptions, so we have to do that ourselves. To keep the code simple, we do not try to detect the target platform or such, we simply append the `\EHsc` flag when we detect clang-cl.
danvratil
force-pushed
the
bugfix/clang-cl-exceptions
branch
from
99aa570 to
b8708a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC requires that exceptions are explicitly enabled using the
\EHflag, so clang-cl copies that behavior. When CMake targets the
Windows-MSVC platform (that is when using "Visual Studio" generator),
CMake takes care of adding
\EHsctoCXXFLAGS. However when theclang-cl compiler is specified manually (
CMAKE_CXX_COMPILER) andanother generator, like Ninja is used, then CMake ends up targeting
the Windows-Clang-CXX platform, which does not enable exceptions,
so we have to do that ourselves. To keep the code simple, we do not
try to detect the target platform or such, we simply append the
\EHscflag when we detect clang-cl.