Add 'Other' option for slave device contact type#222
Closed
TadeasPilar wants to merge 1 commit intoqelectrotech:masterfrom
Closed
Add 'Other' option for slave device contact type#222TadeasPilar wants to merge 1 commit intoqelectrotech:masterfrom
TadeasPilar wants to merge 1 commit intoqelectrotech:masterfrom
Conversation
This option alows for displaying XRef without contact drawing. This is useful for spliting one physical part into multiple logical elements when the slave element is not a switch.
Contributor
|
Merged, thanks |
Contributor
|
Added fix see : https://qelectrotech.org/forum/viewtopic.php?pid=16477#p16477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master - slave elements are super useful for splitting one part into multiple logical elements. This makes schematic much more readable.
My issue is, QET always assumes the slave is a switch. And draws appropriate switch symbol next to the slave link(see pic.). I would like to use the master-slave elements for other parts as well. My specific use-case has power meters with digital outputs. It makes sense to separate the low voltage digital part into second sheet.
There is demand for this among the community. I am not the first one to stumble upon this issue.
link1
link2
This PR adds
Otheroption into the slave switch state selection. If you select this option, and yourCross reference->XRef slave positionis set toView contacts, QET will only draw the XRef without contact type. This change doesn't make sense forcrossstyle of contacts. In that case, no link will be shown.Before:
After:
