Skip to content

Commit

Permalink
vfio/migration: Remove print of "Migration disabled"
Browse files Browse the repository at this point in the history
Property enable_migration supports [on/off/auto].
In ON mode, error pointer is passed to errp and logged.
In OFF mode, we doesn't need to log "Migration disabled" as it's intentional.
In AUTO mode, we should only ever see errors or warnings if the device
supports migration and an error or incompatibility occurs while further
probing or configuring it. Lack of support for migration shoundn't
generate an error or warning.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
  • Loading branch information
duanzhenzhong authored and legoater committed Jul 10, 2023
1 parent 2b43b29 commit 0520d63
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hw/vfio/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -3209,7 +3209,6 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
if (!pdev->failover_pair_id) {
ret = vfio_migration_realize(vbasedev, errp);
if (ret) {
error_report("%s: Migration disabled", vbasedev->name);
goto out_deregister;
}
}
Expand Down

0 comments on commit 0520d63

Please sign in to comment.