Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
contrib/plugins: remove -soname argument
-soname is not needed for runtime-loaded modules.  For example, Meson says:

            if not isinstance(target, build.SharedModule) or target.force_soname:
                # Add -Wl,-soname arguments on Linux, -install_name on OS X
                commands += linker.get_soname_args(
                    self.environment, target.prefix, target.name, target.suffix,
                    target.soversion, target.darwin_versions)

(force_soname is set is shared modules are linked into a build target, which is not
the case here.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Sep 7, 2023
1 parent bb5c77c commit 07c4523
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/plugins/Makefile
Expand Up @@ -37,7 +37,7 @@ all: $(SONAMES)
$(CC) $(CFLAGS) -c -o $@ $<

lib%.so: %.o
$(CC) -shared -Wl,-soname,$@ -o $@ $^ $(LDLIBS)
$(CC) -shared -o $@ $^ $(LDLIBS)

clean:
rm -f *.o *.so *.d
Expand Down

0 comments on commit 07c4523

Please sign in to comment.