Skip to content

Commit

Permalink
iotests: Skip 233 if certtool not installed
Browse files Browse the repository at this point in the history
The use of TLS while building qemu is optional. While the
'certtool' binary should be available on every platform that
supports building against TLS, that does not imply that the
developer has installed it.  Make the test gracefully skip
in that case.

Reported-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
ebblake authored and kevmw committed Nov 21, 2018
1 parent fa1cfb4 commit 155af09
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/qemu-iotests/common.tls
Expand Up @@ -31,6 +31,9 @@ tls_x509_cleanup()

tls_x509_init()
{
(certtool --help) >/dev/null 2>&1 || \
_notrun "certtool utility not found, skipping test"

mkdir -p "${tls_dir}"

# use a fixed key so we don't waste system entropy on
Expand Down

0 comments on commit 155af09

Please sign in to comment.