Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
build: remove git submodule handling from main makefile
The only remaining user of submodules at build time is roms/SLOF,
which is handled in pc-bios/s390-ccw/Makefile.  Remove the relevant
code from the main makefile.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Jun 6, 2023
1 parent d2dfe0b commit 1f46815
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 20 deletions.
3 changes: 1 addition & 2 deletions .gitlab-ci.d/buildtest-template.yml
Expand Up @@ -42,8 +42,7 @@
stage: test
image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
script:
- scripts/git-submodule.sh update
roms/SLOF $(sed -n '/GIT_SUBMODULES=/ s/.*=// p' build/config-host.mak)
- scripts/git-submodule.sh update roms/SLOF
- meson subprojects download $(cd build/subprojects && echo *)
- cd build
- find . -type f -exec touch {} +
Expand Down
10 changes: 0 additions & 10 deletions Makefile
Expand Up @@ -45,16 +45,6 @@ include config-host.mak
include Makefile.prereqs
Makefile.prereqs: config-host.mak

git-submodule-update:
.git-submodule-status: git-submodule-update config-host.mak
Makefile: .git-submodule-status

.PHONY: git-submodule-update
git-submodule-update:
ifneq ($(GIT_SUBMODULES_ACTION),ignore)
$(quiet-@)GIT=git "$(SRC_PATH)/scripts/git-submodule.sh" $(GIT_SUBMODULES_ACTION) $(GIT_SUBMODULES)
endif

# 0. ensure the build tree is okay

# Check that we're not trying to do an out-of-tree build from
Expand Down
7 changes: 0 additions & 7 deletions configure
Expand Up @@ -253,7 +253,6 @@ else
git_submodules_action="ignore"
fi

git_submodules=""
git="git"
debug_tcg="no"
docs="auto"
Expand Down Expand Up @@ -1657,18 +1656,12 @@ fi
#######################################
# generate config-host.mak

if ! (GIT=git "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
exit 1
fi

config_host_mak="config-host.mak"

echo "# Automatically generated by configure - do not modify" > $config_host_mak
echo >> $config_host_mak

echo all: >> $config_host_mak
echo "GIT_SUBMODULES=$git_submodules" >> $config_host_mak
echo "GIT_SUBMODULES_ACTION=$git_submodules_action" >> $config_host_mak

if test "$debug_tcg" = "yes" ; then
echo "CONFIG_DEBUG_TCG=y" >> $config_host_mak
Expand Down
1 change: 0 additions & 1 deletion meson.build
Expand Up @@ -3976,7 +3976,6 @@ endif
summary_info = {}
summary_info += {'Build directory': meson.current_build_dir()}
summary_info += {'Source path': meson.current_source_dir()}
summary_info += {'GIT submodules': config_host['GIT_SUBMODULES']}
summary_info += {'Download dependencies': get_option('wrap_mode') != 'nodownload'}
summary(summary_info, bool_yn: true, section: 'Build environment')

Expand Down

0 comments on commit 1f46815

Please sign in to comment.