Skip to content

Commit

Permalink
linux-user/microblaze: Use force_sig_fault
Browse files Browse the repository at this point in the history
Use the new function instead of setting up a target_siginfo_t
and calling queue_signal. Fill in the missing PC for SIGTRAP.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220107213243.212806-13-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
  • Loading branch information
rth7680 authored and vivier committed Jan 11, 2022
1 parent 71dc6f7 commit 23ae825
Showing 1 changed file with 25 additions and 36 deletions.
61 changes: 25 additions & 36 deletions linux-user/microblaze/cpu_loop.c
Expand Up @@ -27,9 +27,8 @@
void cpu_loop(CPUMBState *env)
{
CPUState *cs = env_cpu(env);
int trapnr, ret;
target_siginfo_t info;

int trapnr, ret, si_code;

while (1) {
cpu_exec_start(cs);
trapnr = cpu_exec(cs);
Expand All @@ -38,8 +37,8 @@ void cpu_loop(CPUMBState *env)

switch (trapnr) {
case EXCP_INTERRUPT:
/* just indicate that signals should be handled asap */
break;
/* just indicate that signals should be handled asap */
break;
case EXCP_SYSCALL:
/* Return address is 4 bytes after the call. */
env->regs[14] += 4;
Expand Down Expand Up @@ -67,49 +66,39 @@ void cpu_loop(CPUMBState *env)
*/
env->regs[14] = env->pc;
break;

case EXCP_HW_EXCP:
env->regs[17] = env->pc + 4;
if (env->iflags & D_FLAG) {
env->esr |= 1 << 12;
env->pc -= 4;
/* FIXME: if branch was immed, replay the imm as well. */
}

env->iflags &= ~(IMM_FLAG | D_FLAG);

switch (env->esr & 31) {
case ESR_EC_DIVZERO:
info.si_signo = TARGET_SIGFPE;
info.si_errno = 0;
info.si_code = TARGET_FPE_FLTDIV;
info._sifields._sigfault._addr = 0;
queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
break;
case ESR_EC_FPU:
info.si_signo = TARGET_SIGFPE;
info.si_errno = 0;
if (env->fsr & FSR_IO) {
info.si_code = TARGET_FPE_FLTINV;
}
if (env->fsr & FSR_DZ) {
info.si_code = TARGET_FPE_FLTDIV;
}
info._sifields._sigfault._addr = 0;
queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
break;
default:
fprintf(stderr, "Unhandled hw-exception: 0x%x\n",
env->esr & ESR_EC_MASK);
cpu_dump_state(cs, stderr, 0);
exit(EXIT_FAILURE);
break;
case ESR_EC_DIVZERO:
si_code = TARGET_FPE_FLTDIV;
break;
case ESR_EC_FPU:
si_code = 0;
if (env->fsr & FSR_IO) {
si_code = TARGET_FPE_FLTINV;
}
if (env->fsr & FSR_DZ) {
si_code = TARGET_FPE_FLTDIV;
}
break;
default:
fprintf(stderr, "Unhandled hw-exception: 0x%x\n",
env->esr & ESR_EC_MASK);
cpu_dump_state(cs, stderr, 0);
exit(EXIT_FAILURE);
}
force_sig_fault(TARGET_SIGFPE, si_code, env->pc);
break;

case EXCP_DEBUG:
info.si_signo = TARGET_SIGTRAP;
info.si_errno = 0;
info.si_code = TARGET_TRAP_BRKPT;
queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->pc);
break;
case EXCP_ATOMIC:
cpu_exec_step_atomic(cs);
Expand Down

0 comments on commit 23ae825

Please sign in to comment.