From 3622634bc665244c2fd4382301cfadcef1a9e934 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Wed, 29 Jun 2016 10:47:26 +0200 Subject: [PATCH] linux-user: Clean up target_syscall.h header guards Some of them use guard symbol TARGET_SYSCALL_H, but we also have CRIS_SYSCALL_H, MICROBLAZE_SYSCALLS_H, TILEGX_SYSCALLS_H and __UC32_SYSCALL_H__. They all upset scripts/clean-header-guards.pl. Reuse of the same guard symbol TARGET_SYSCALL_H in multiple headers is okay as long as they cannot be included together. The script can't tell, so it warns. The script dislikes the other guard symbols, too. They don't match their file name (they should, to make guard collisions less likely), and __UC32_SYSCALL_H__ is a reserved identifier. Clean them all up: use guard symbol $target_TARGET_SYSCALL_H for linux-user/$target/target_sycall.h. Signed-off-by: Markus Armbruster Reviewed-by: Richard Henderson --- linux-user/aarch64/target_syscall.h | 6 +++--- linux-user/alpha/target_syscall.h | 6 +++--- linux-user/arm/target_syscall.h | 6 +++--- linux-user/cris/target_syscall.h | 4 ++-- linux-user/i386/target_syscall.h | 6 +++--- linux-user/m68k/target_syscall.h | 6 +++--- linux-user/microblaze/target_syscall.h | 4 ++-- linux-user/mips/target_syscall.h | 6 +++--- linux-user/mips64/target_syscall.h | 6 +++--- linux-user/openrisc/target_syscall.h | 6 +++--- linux-user/ppc/target_syscall.h | 6 +++--- linux-user/s390x/target_syscall.h | 6 +++--- linux-user/sh4/target_syscall.h | 6 +++--- linux-user/sparc/target_syscall.h | 6 +++--- linux-user/sparc64/target_syscall.h | 6 +++--- linux-user/tilegx/target_syscall.h | 4 ++-- linux-user/unicore32/target_syscall.h | 8 +++++--- linux-user/x86_64/target_syscall.h | 6 +++--- 18 files changed, 53 insertions(+), 51 deletions(-) diff --git a/linux-user/aarch64/target_syscall.h b/linux-user/aarch64/target_syscall.h index f45801804897..1b62953eeb2b 100644 --- a/linux-user/aarch64/target_syscall.h +++ b/linux-user/aarch64/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef AARCH64_TARGET_SYSCALL_H +#define AARCH64_TARGET_SYSCALL_H struct target_pt_regs { uint64_t regs[31]; @@ -15,4 +15,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* AARCH64_TARGET_SYSCALL_H */ diff --git a/linux-user/alpha/target_syscall.h b/linux-user/alpha/target_syscall.h index 3db4b16f6b53..b580fc5b3733 100644 --- a/linux-user/alpha/target_syscall.h +++ b/linux-user/alpha/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef ALPHA_TARGET_SYSCALL_H +#define ALPHA_TARGET_SYSCALL_H /* default linux values for the selectors */ #define __USER_DS (1) @@ -259,4 +259,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 0x2000 #define TARGET_MLOCKALL_MCL_FUTURE 0x4000 -#endif /* TARGET_SYSCALL_H */ +#endif /* ALPHA_TARGET_SYSCALL_H */ diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h index 11077b761bcd..cd021ff598cd 100644 --- a/linux-user/arm/target_syscall.h +++ b/linux-user/arm/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef ARM_TARGET_SYSCALL_H +#define ARM_TARGET_SYSCALL_H /* this struct defines the way the registers are stored on the stack during a system call. */ @@ -33,4 +33,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* ARM_TARGET_SYSCALL_H */ diff --git a/linux-user/cris/target_syscall.h b/linux-user/cris/target_syscall.h index 2957b0d6ae61..29d69009ffe8 100644 --- a/linux-user/cris/target_syscall.h +++ b/linux-user/cris/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef CRIS_SYSCALL_H -#define CRIS_SYSCALL_H 1 +#ifndef CRIS_TARGET_SYSCALL_H +#define CRIS_TARGET_SYSCALL_H #define UNAME_MACHINE "cris" #define UNAME_MINIMUM_RELEASE "2.6.32" diff --git a/linux-user/i386/target_syscall.h b/linux-user/i386/target_syscall.h index 0ac84dc02fe0..b4e895fd9c0c 100644 --- a/linux-user/i386/target_syscall.h +++ b/linux-user/i386/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef I386_TARGET_SYSCALL_H +#define I386_TARGET_SYSCALL_H /* default linux values for the selectors */ #define __USER_CS (0x23) @@ -154,4 +154,4 @@ struct target_vm86plus_struct { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* I386_TARGET_SYSCALL_H */ diff --git a/linux-user/m68k/target_syscall.h b/linux-user/m68k/target_syscall.h index 97a4cc0cbd43..db2be4f10126 100644 --- a/linux-user/m68k/target_syscall.h +++ b/linux-user/m68k/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef M68K_TARGET_SYSCALL_H +#define M68K_TARGET_SYSCALL_H /* this struct defines the way the registers are stored on the stack during a system call. */ @@ -26,4 +26,4 @@ struct target_pt_regs { void do_m68k_simcall(CPUM68KState *, int); -#endif /* TARGET_SYSCALL_H */ +#endif /* M68K_TARGET_SYSCALL_H */ diff --git a/linux-user/microblaze/target_syscall.h b/linux-user/microblaze/target_syscall.h index 3c1ed27c04a3..0b6980c89986 100644 --- a/linux-user/microblaze/target_syscall.h +++ b/linux-user/microblaze/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef MICROBLAZE_SYSCALLS_H -#define MICROBLAZE_SYSCALLS_H 1 +#ifndef MICROBLAZE_TARGET_SYSCALL_H +#define MICROBLAZE_TARGET_SYSCALL_H #define UNAME_MACHINE "microblaze" #define UNAME_MINIMUM_RELEASE "2.6.32" diff --git a/linux-user/mips/target_syscall.h b/linux-user/mips/target_syscall.h index e8e305cc9c19..2b4f39072921 100644 --- a/linux-user/mips/target_syscall.h +++ b/linux-user/mips/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef MIPS_TARGET_SYSCALL_H +#define MIPS_TARGET_SYSCALL_H /* this struct defines the way the registers are stored on the stack during a system call. */ @@ -230,4 +230,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* MIPS_TARGET_SYSCALL_H */ diff --git a/linux-user/mips64/target_syscall.h b/linux-user/mips64/target_syscall.h index 5789e8615078..8da9c1f9cc4b 100644 --- a/linux-user/mips64/target_syscall.h +++ b/linux-user/mips64/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef MIPS64_TARGET_SYSCALL_H +#define MIPS64_TARGET_SYSCALL_H /* this struct defines the way the registers are stored on the stack during a system call. */ @@ -227,4 +227,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* MIPS64_TARGET_SYSCALL_H */ diff --git a/linux-user/openrisc/target_syscall.h b/linux-user/openrisc/target_syscall.h index 19aeffc95d08..9d3380f9a8de 100644 --- a/linux-user/openrisc/target_syscall.h +++ b/linux-user/openrisc/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef OPENRISC_TARGET_SYSCALL_H +#define OPENRISC_TARGET_SYSCALL_H struct target_pt_regs { union { @@ -31,4 +31,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* OPENRISC_TARGET_SYSCALL_H */ diff --git a/linux-user/ppc/target_syscall.h b/linux-user/ppc/target_syscall.h index 7ca83c228093..a8662f48562d 100644 --- a/linux-user/ppc/target_syscall.h +++ b/linux-user/ppc/target_syscall.h @@ -17,8 +17,8 @@ * License along with this library; if not, see . */ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef PPC_TARGET_SYSCALL_H +#define PPC_TARGET_SYSCALL_H /* XXX: ABSOLUTELY BUGGY: * for now, this is quite just a cut-and-paste from i386 target... @@ -75,4 +75,4 @@ struct target_revectored_struct { #define TARGET_MLOCKALL_MCL_CURRENT 0x2000 #define TARGET_MLOCKALL_MCL_FUTURE 0x4000 -#endif /* TARGET_SYSCALL_H */ +#endif /* PPC_TARGET_SYSCALL_H */ diff --git a/linux-user/s390x/target_syscall.h b/linux-user/s390x/target_syscall.h index 02061efc780a..8d4f609eaa5d 100644 --- a/linux-user/s390x/target_syscall.h +++ b/linux-user/s390x/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef S390X_TARGET_SYSCALL_H +#define S390X_TARGET_SYSCALL_H /* this typedef defines how a Program Status Word looks like */ typedef struct { @@ -31,4 +31,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* S390X_TARGET_SYSCALL_H */ diff --git a/linux-user/sh4/target_syscall.h b/linux-user/sh4/target_syscall.h index 9f3381bc9b73..78d55571246b 100644 --- a/linux-user/sh4/target_syscall.h +++ b/linux-user/sh4/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef SH4_TARGET_SYSCALL_H +#define SH4_TARGET_SYSCALL_H struct target_pt_regs { unsigned long regs[16]; @@ -19,4 +19,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* SH4_TARGET_SYSCALL_H */ diff --git a/linux-user/sparc/target_syscall.h b/linux-user/sparc/target_syscall.h index a73fa6dae147..326f674b4e79 100644 --- a/linux-user/sparc/target_syscall.h +++ b/linux-user/sparc/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef SPARC_TARGET_SYSCALL_H +#define SPARC_TARGET_SYSCALL_H struct target_pt_regs { abi_ulong psr; @@ -22,4 +22,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 0x2000 #define TARGET_MLOCKALL_MCL_FUTURE 0x4000 -#endif /* TARGET_SYSCALL_H */ +#endif /* SPARC_TARGET_SYSCALL_H */ diff --git a/linux-user/sparc64/target_syscall.h b/linux-user/sparc64/target_syscall.h index eb827fcac16d..b7e3bf82fb6b 100644 --- a/linux-user/sparc64/target_syscall.h +++ b/linux-user/sparc64/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef SPARC64_TARGET_SYSCALL_H +#define SPARC64_TARGET_SYSCALL_H struct target_pt_regs { abi_ulong u_regs[16]; @@ -23,4 +23,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 0x2000 #define TARGET_MLOCKALL_MCL_FUTURE 0x4000 -#endif /* TARGET_SYSCALL_H */ +#endif /* SPARC64_TARGET_SYSCALL_H */ diff --git a/linux-user/tilegx/target_syscall.h b/linux-user/tilegx/target_syscall.h index a938d4e90c9e..d731acdafaa0 100644 --- a/linux-user/tilegx/target_syscall.h +++ b/linux-user/tilegx/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TILEGX_SYSCALLS_H -#define TILEGX_SYSCALLS_H +#ifndef TILEGX_TARGET_SYSCALL_H +#define TILEGX_TARGET_SYSCALL_H #define UNAME_MACHINE "tilegx" #define UNAME_MINIMUM_RELEASE "3.19" diff --git a/linux-user/unicore32/target_syscall.h b/linux-user/unicore32/target_syscall.h index 385a97562dc2..346b20770005 100644 --- a/linux-user/unicore32/target_syscall.h +++ b/linux-user/unicore32/target_syscall.h @@ -5,8 +5,10 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ -#ifndef __UC32_SYSCALL_H__ -#define __UC32_SYSCALL_H__ + +#ifndef UNICORE32_TARGET_SYSCALL_H +#define UNICORE32_TARGET_SYSCALL_H + struct target_pt_regs { abi_ulong uregs[34]; }; @@ -57,4 +59,4 @@ struct target_pt_regs { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* __UC32_SYSCALL_H__ */ +#endif /* UNICORE32_TARGET_SYSCALL_H */ diff --git a/linux-user/x86_64/target_syscall.h b/linux-user/x86_64/target_syscall.h index feecd32d5046..983fb23d9b1d 100644 --- a/linux-user/x86_64/target_syscall.h +++ b/linux-user/x86_64/target_syscall.h @@ -1,5 +1,5 @@ -#ifndef TARGET_SYSCALL_H -#define TARGET_SYSCALL_H +#ifndef X86_64_TARGET_SYSCALL_H +#define X86_64_TARGET_SYSCALL_H #define __USER_CS (0x33) #define __USER_DS (0x2B) @@ -104,4 +104,4 @@ struct target_msqid64_ds { #define TARGET_MLOCKALL_MCL_CURRENT 1 #define TARGET_MLOCKALL_MCL_FUTURE 2 -#endif /* TARGET_SYSCALL_H */ +#endif /* X86_64_TARGET_SYSCALL_H */