From 373df5b135b4a54e0abb394e9e703fef3ded093c Mon Sep 17 00:00:00 2001 From: Fam Zheng Date: Tue, 29 Apr 2014 18:09:09 +0800 Subject: [PATCH] mirror: Fix resource leak when bdrv_getlength fails The direct return will skip releasing of all the resouces at immediate_exit, don't miss that. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 95366adb3a55..403714c1ea35 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -325,8 +325,8 @@ static void coroutine_fn mirror_run(void *opaque) s->common.len = bdrv_getlength(bs); if (s->common.len <= 0) { - block_job_completed(&s->common, s->common.len); - return; + ret = s->common.len; + goto immediate_exit; } length = DIV_ROUND_UP(s->common.len, s->granularity);