From 3e1dd459cbd95c66753f7c9368e680dde2ba60e2 Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Tue, 25 Sep 2018 14:02:32 +0100 Subject: [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add 'break' statements missing from a switch in the APB dual-timer write function. Spotted by Coverity as CID 1395626 and 1395633. Reported-by: Paolo Bonzini Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180924123122.14549-1-peter.maydell@linaro.org --- hw/timer/cmsdk-apb-dualtimer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/timer/cmsdk-apb-dualtimer.c b/hw/timer/cmsdk-apb-dualtimer.c index ccd49753b7fb..30245990f34f 100644 --- a/hw/timer/cmsdk-apb-dualtimer.c +++ b/hw/timer/cmsdk-apb-dualtimer.c @@ -296,9 +296,11 @@ static void cmsdk_apb_dualtimer_write(void *opaque, hwaddr offset, case A_TIMERITCR: s->timeritcr = value & R_TIMERITCR_VALID_MASK; cmsdk_apb_dualtimer_update(s); + break; case A_TIMERITOP: s->timeritop = value & R_TIMERITOP_VALID_MASK; cmsdk_apb_dualtimer_update(s); + break; default: bad_offset: qemu_log_mask(LOG_GUEST_ERROR,